Skip to content

Commit

Permalink
fix(app-events)!: remove updateUserProperties method
Browse files Browse the repository at this point in the history
BREAKING CHANGE: upstream SDKs removed updateUserProperties, there is no replacement
  • Loading branch information
mikehardy committed Nov 9, 2021
1 parent b3b5726 commit a4e49ca
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 27 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -310,17 +310,6 @@ public void getAttributionID(Promise promise) {
}
}

/**
* Sends a request to update the properties for the current user, set by
* setUserID. You must call setUserID before making this call.
*
* @param parameters Key-value pairs representing user properties and their values.
*/
@ReactMethod
public void updateUserProperties(ReadableMap parameters) {
mAppEventLogger.updateUserProperties(Arguments.toBundle(parameters), null);
}

private @Nullable String getNullableString(ReadableMap data, String key) {
return data.hasKey(key) ? data.getString(key) : null;
}
Expand Down
11 changes: 0 additions & 11 deletions src/FBAppEventsLogger.js
Original file line number Diff line number Diff line change
Expand Up @@ -335,17 +335,6 @@ module.exports = {
return await AppEventsLogger.getAttributionID();
},

/**
* Sends a request to update the properties for the current user, set by
* setUserID. You must call setUserID before making this call.
*/
updateUserProperties(parameters: Params) {
if (Platform.OS === 'ios') {
return;
}
AppEventsLogger.updateUserProperties(parameters);
},

/**
* Set additional data about the user to increase chances of matching a Facebook user.
*/
Expand Down
5 changes: 0 additions & 5 deletions types/FBAppEventsLogger.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -183,11 +183,6 @@ export type FBAppEventsLogger = {
* @platform android
*/
getAttributionID(): Promise<string | undefined | null>;
/**
* Sends a request to update the properties for the current user, set by
* setUserID. You must call setUserID before making this call.
*/
updateUserProperties(parameters: Params): void;
/**
* Set additional data about the user to increase chances of matching a Facebook user.
*/
Expand Down

0 comments on commit a4e49ca

Please sign in to comment.