fix(path): honor empty parse and format fields#56
Conversation
|
Hi @ShiroKSH, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/theMackabu/ant/blob/master/CONTRIBUTING.md for more details. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughPath parsing now returns empty directories for basename-only paths. Path formatting distinguishes missing or empty ChangesPath component handling
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
vouch @ShiroKSH |
Summary
Root cause
path.parse substituted a dot for a missing directory. path.format chose dir and base from their property type instead of their non-empty values.
Checks
Summary by CodeRabbit
Bug Fixes
Tests