Ignore MySQL indices with prefix key parts #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Btree indices on prefix keys (e.g. col_name(5) meaning the first 5 characters of "col_name") were previously being replicated as indices on the full column. This can cause errors in the case of columns with values too wide to fit in indices; and regardless produces a non-equivalent schema on the target. PostgreSQL doesn't seem to have a direct equivalent for this type of index, so my fix is just to ignore these indices, as is done for non-BTREE indices.
acarapetis
force-pushed
the
ignore-indices-with-sub-parts
branch
from
6db01f3 to
1dfdba6
Compare
|
thanks for your PR. |
Will do - didn't remember this branch was linked to this PR when I pushed those changes, my bad! |
acarapetis
force-pushed
the
ignore-indices-with-sub-parts
branch
from
86eabbc to
1dfdba6
Compare
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Btree indices on prefix keys (e.g. col_name(5) meaning the first 5 characters of "col_name") were previously being replicated as indices on the full column. This can cause errors in the case of columns with values too wide to fit in indices; and regardless produces a non-equivalent schema on the target.
PostgreSQL doesn't seem to have a direct equivalent for this type of index, so my fix is just to ignore these indices, as is done for non-BTREE indices.