[Android] Support showing Google Maps-like BottomSheet. #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: - Currently the BottomSheet implementation (on Android) always shows Z-order wise above other components like bottom navigation bar, tab bars, and flyouts. - Google Maps shows a BottomSheet that is "within" the page - the sheet shows up vertically above (rather than in front of) the bottom navigation/tab bars. - To implement such an experience, rather than adding the BottomSheet StayOnFrontView to the root ViewGroup, instead add it as a sibling of AppBarLayout. - This ensures that the BottomSheet shows up behind the navigation bar/Tab bar on the bottom (BottomNavigationView) and the flyouts. Changes: 1. BottomSheet, BottomSheetManager: - Provide another overload of ShowAsync to accept a Page. 2. Android: - Update EnsureStayOnFrontView to show as a sibling of AppBarLayout when showing "inside" a page. 3. sample: - AppShell: Force showing the bottom tab bar, and the flyout menu option. - MainPage: add test cases for modal and non-modal for the Google Maps style behavior. This PR has no changes to any existing behavior or usage.
|
Should address #115 |
softlion
added a commit
to softlion/The49.Maui.BottomSheet
that referenced
this pull request
Nov 7, 2024
- [android] Fix "no sliding away" blocked in hidden mode - [android] Fix bottom sheet sometime displayed in hidden mode - [android] Fix handle not appearing - [android] [Demo app] Fix can't open the same demo item twice in a row - Breaking: removed DetentsCollection. Use a ResourceDictionary to choose between detents with OnPlatform
softlion
added a commit
to softlion/The49.Maui.BottomSheet
that referenced
this pull request
Nov 7, 2024
- [android] Fix "no sliding away" blocked in hidden mode - [android] Fix bottom sheet sometime displayed in hidden mode - [android] Fix handle not appearing - [android] [Demo app] Fix can't open the same demo item twice in a row - Breaking: removed DetentsCollection. Use a ResourceDictionary to choose between detents with OnPlatform
|
Merged into that nuget, along with many fixes, oriented on stability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Changes:
This PR has no changes to any existing behavior or usage.
Google Maps style:
(Regular sheets, unchanged behavior)
