Skip to content

Conversation

@mmcqd
Copy link
Contributor

@mmcqd mmcqd commented Aug 20, 2025

Description

This PR defines displayed bicategories, along with some prerequisites like displayed categories of displayed functors.
The prose in the definition of displayed bicategories feels kinda repetitive (whole bunch of "and then we have a displayed version of that"), but I wasn't sure what else to write 😅.

Just a definition for now, some actual theorems about them coming soon.

Checklist

Before submitting a merge request, please check the items below:

  • I've read the contributing guidelines.
  • The imports of new modules have been sorted with support/sort-imports.hs (or nix run --experimental-features nix-command -f . sort-imports).
  • All new code blocks have "agda" as their language.

If your change affects many files without adding substantial content, and
you don't want your name to appear on those pages (for example, treewide
refactorings or reformattings), start the commit message and PR title with chore:.

@Lavenza
Copy link
Member

Lavenza commented Aug 20, 2025

Copy link
Member

@plt-amy plt-amy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff, here's some formatting nits i noticed on a skim.

(there's a whole lot of "blank lines around code blocks" to point out but i don't want to leave like 50 identical comments. generally every block level element— comments, code, paragraph, lists— needs to be surrounded with blank lines)

@mmcqd mmcqd requested a review from plt-amy August 21, 2025 07:03
@mmcqd
Copy link
Contributor Author

mmcqd commented Aug 21, 2025

The build seems to have stalled 🤔
I was able to build it locally, might just need to re-run

@mmcqd mmcqd requested a review from plt-amy August 27, 2025 20:53
@mmcqd
Copy link
Contributor Author

mmcqd commented Aug 27, 2025

Tried to make the changes in Cat.Displayed.Reasoning line up with the rest of the file, but happy to change them back if preferred

→ {A' : Ob[ A ]} {B' : Ob[ B ]}
→ A' [ f ]↦ B' → (f ⇒ g) → A' [ g ]↦ B'
→ Type _
_[_]⇒_ {A' = A'} {B' = B'} f' α g' = Hom[ A' , B' ] .Displayed.Hom[_] α f' g'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_[_]⇒_ {A' = A'} {B' = B'} f' α g' = Hom[ A' , B' ] .Displayed.Hom[_] α f' g'
_[_]⇒_ {A' = A'} {B' = B'} f' φ g' = Hom[ A' , B' ] .Displayed.Hom[_] φ f' g'

maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants