Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TVB-2719 Remove 2 unused .py files #56

Merged
merged 1 commit into from
Aug 3, 2020
Merged

TVB-2719 Remove 2 unused .py files #56

merged 1 commit into from
Aug 3, 2020

Conversation

ayan-b
Copy link
Member

@ayan-b ayan-b commented Jul 29, 2020

No description provided.

@ayan-b ayan-b self-assigned this Jul 29, 2020
@ayan-b ayan-b changed the title Remove 2 files TVB-2719 Remove 2 files Jul 30, 2020
@liadomide liadomide requested a review from maedoc August 3, 2020 15:26
@liadomide liadomide added this to the GSOC2020 milestone Aug 3, 2020
@liadomide
Copy link
Member

liadomide commented Aug 3, 2020 •
edited
Loading

Indeed, these 2 files seem unused, they are identical - except for the name, top header and some white characters.
@maedoc Could we remove them (in the context of code coverage), or do you see potential for the immediate or mid term usage ?

@maedoc
Copy link
Member

maedoc commented Aug 3, 2020

Yes, please, this can be removed without problem.

@liadomide liadomide merged commit da6c8f5 into the-virtual-brain:trunk Aug 3, 2020
@liadomide liadomide changed the title TVB-2719 Remove 2 files TVB-2719 Remove 2 unused .py files Aug 3, 2020
@ayan-b ayan-b deleted the remove branch August 4, 2020 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maedoc maedoc Awaiting requested review from maedoc

Assignees

@ayan-b ayan-b

Labels
enhancement question
Projects
None yet
Milestone
GSOC2020
Development

Successfully merging this pull request may close these issues.
3 participants
@ayan-b @liadomide @maedoc