Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NK_ Classic TKL ISO #2348

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Add NK_ Classic TKL ISO #2348

merged 2 commits into from
Oct 8, 2024

Conversation

yiancar
Copy link
Collaborator

@yiancar yiancar commented Oct 8, 2024

Description

QMK Pull Request

qmk/qmk_firmware#24434

VIA Keymap Pull Request

the-via/qmk_userspace_via#9

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • VIA keymap is MERGED in VIA userspace master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have formatted the JSON file to have consistent formatting with the rest of the repository.
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Cipulot
Copy link
Collaborator

Cipulot commented Oct 8, 2024

LGTM

@Cipulot Cipulot merged commit 3429b8d into the-via:master Oct 8, 2024
2 checks passed
@yiancar yiancar deleted the nk_classic_tkl_iso branch October 8, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants