Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added skiller_sgk50_s4 keyboard #2282

Merged
merged 1 commit into from
May 31, 2024
Merged

Added skiller_sgk50_s4 keyboard #2282

merged 1 commit into from
May 31, 2024

Conversation

itarze
Copy link
Contributor

@itarze itarze commented May 1, 2024

Description

Added skiller_sgk50_s4 keyboard.

QMK Pull Request

qmk/qmk_firmware#23636

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have formatted the JSON file to have consistent formatting with the rest of the repository.
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@itarze
Copy link
Contributor Author

itarze commented May 20, 2024

Can merge?

@Xelus22 Xelus22 merged commit 3fb93f4 into the-via:master May 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itarze @Xelus22