Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Sofle choc #2139

Merged
merged 7 commits into from
Jul 6, 2024
Merged

Adds Sofle choc #2139

merged 7 commits into from
Jul 6, 2024

Conversation

JellyTitan
Copy link
Contributor

The Sofle Choc has a separate directory from the other Sofle keyboards in QMK. I think it makes sense to maintain the separation here as well.
image

Description

QMK Pull Request

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Hurray! It works!
Verified Sofle Pico VIA support

This was referenced Jan 11, 2024
Closed
Closed
Xelus22
Xelus22 requested changes Feb 3, 2024
View reviewed changes
v3/sofle_pico/sofle_pico.json Outdated Show resolved Hide resolved
Xelus22
Xelus22 requested changes Feb 4, 2024
View reviewed changes
v3/sofle_choc/sofle_choc.json Outdated Show resolved Hide resolved
@JellyTitan JellyTitan mentioned this pull request Feb 14, 2024
Closed
14 tasks
@JellyTitan JellyTitan mentioned this pull request Mar 12, 2024
Closed
@JellyTitan JellyTitan mentioned this pull request Jul 1, 2024
Merged
14 tasks
@JellyTitan
Updates VID/PID to be unique
b53427a 
This update aligns the VIA pid/vid with the updated pid/vid now in QMK master. 
This updated pid/vid was merged into qmk master today with this PR:
qmk/qmk_firmware#24030
@JellyTitan
Merge branch 'the-via:master' into sofle_choc
99e9a22
@JellyTitan
Copy link
Contributor Author

The PR to make the Sofle Choc PId/Vid Unique was accepted and merged into QMK master.
I updated the Sofle Choc VIA PR to match the update VID/PID.
Ready for review!

@JellyTitan JellyTitan requested a review from Xelus22 July 4, 2024 22:34
@Xelus22
Copy link
Collaborator

Xelus22 commented Jul 6, 2024

qmk/qmk_firmware#24030

@Xelus22 Xelus22 merged commit 81b9701 into the-via:master Jul 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JellyTitan @Xelus22