print-ip6.c: make '-v' output similar to print-ip.c #1335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the output for IPv6 packets from "everything in one line, and the length printed is the payload length only" to a two-line format, which has the overall packet length in the first line, and the payload length in the second line. The old '-v' format printed everything in one line, with only the payload length at a different place, suppressing the payload length for ICMPv6 packets - so this check is removed, we intentionally print two length fields like for IPv4. This is helpful when trying to be really sure about packet sizes when debugging MTU issues etc. The actual code change is very small but the commit is huge as a large number of test cases are affected. The new '-g' option is taken into account as well. Github: implements the-tcpdump-group#810
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the output for IPv6 packets from "everything in one line, and the length printed is the payload length only" to a two-line format, which has the overall packet length in the first line, and the payload length in the second line.
The old '-v' format printed everything in one line, with only the payload length at a different place, suppressing the payload length for ICMPv6 packets - so this check is removed, we intentionally print two length fields like for IPv4. This is helpful when trying to be really sure about packet sizes when debugging MTU issues etc.
The actual code change is very small but the commit is huge as a large number of test cases are affected.
The new '-g' option is taken into account as well.
Github: implements #810