Merged
Conversation
BatMiles
reviewed
Nov 22, 2024
| let targets = document.querySelectorAll(change.selector); | ||
| for (let target of targets) { | ||
| if (change.change == 'add') { | ||
| target.classList.add(change.class); |
Member
There was a problem hiding this comment.
I'm missing something - wouldn't this code mean that the added/removed classes were always added/removed?
Contributor
Author
There was a problem hiding this comment.
Well it'll happen every time a variant lands on the page with a class add/removal, but that will only happen some of the time. fwiw DomTests.php:76 is where that random selection happens.
BatMiles
approved these changes
Nov 22, 2024
Member
BatMiles
left a comment
BatMiles
left a comment
There was a problem hiding this comment.
Tested locally, looks good! Left one code question
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a "change classes" aspect to DOM tests: add a class or remove a class.
Example: "turn the nav donate button pink"
