clippy
4 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 4 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.75.0 (82e1608df 2023-12-21)
- cargo 1.75.0 (1d8b05cdd 2023-11-20)
- clippy 0.1.75 (82e1608 2023-12-21)
Annotations
Check warning on line 229 in libs/federation_query_planner/src/lib.rs
github-actions / clippy
deref which would be done by auto-deref
warning: deref which would be done by auto-deref
--> libs/federation_query_planner/src/lib.rs:229:35
|
229 | .on_upstream_http_request(&mut *request_context, &mut upstream_request)
| ^^^^^^^^^^^^^^^^^^^^^ help: try: `request_context`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
= note: `#[warn(clippy::explicit_auto_deref)]` on by default
Check warning on line 229 in libs/federation_query_planner/src/lib.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> libs/federation_query_planner/src/lib.rs:229:35
|
229 | .on_upstream_http_request(&mut *request_context, &mut upstream_request)
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `(*request_context)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
Check warning on line 69 in libs/federation_query_planner/src/lib.rs
github-actions / clippy
accessing first element with `query_plan.parallel_steps.get(0)`
warning: accessing first element with `query_plan.parallel_steps.get(0)`
--> libs/federation_query_planner/src/lib.rs:69:26
|
69 | let parallel_block = query_plan.parallel_steps.get(0).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `query_plan.parallel_steps.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
= note: `#[warn(clippy::get_first)]` on by default
Check warning on line 44 in libs/tracing/src/minitrace_mgr.rs
github-actions / clippy
this `MutexGuard` is held across an `await` point
warning: this `MutexGuard` is held across an `await` point
--> libs/tracing/src/minitrace_mgr.rs:44:11
|
44 | let mut reporter = reporter
| ^^^^^^^^^^^^
|
= help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling await
note: these are all the `await` points this lock is held through
--> libs/tracing/src/minitrace_mgr.rs:48:24
|
48 | reporter.flush().await
| ^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock
= note: `#[warn(clippy::await_holding_lock)]` on by default