fix(deps): update rust crate insta to 1.37.0 #543

renovate · 2024-03-26T11:49:36Z

This PR contains the following updates:

Package	Type	Update	Change
insta (source)	dependencies	minor	`1.36.1` -> `1.37.0`
insta (source)	dev-dependencies	minor	`1.36.1` -> `1.37.0`

Release Notes

mitsuhiko/insta (insta)

`v1.37.0`

Compare Source

All macros for file snapshots should now handle trailing commas (but not yet inline snapshots)
Vendored old yaml-rust dependency to avoid rustsec warnings. #465

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

github-actions · 2024-03-26T11:50:00Z

🚨 Rust Panic Audit: 102 Potential Panic Points Detected 🚨

Crate: `federation_query_planner`

📊 Total Usages: 53

🚨 panic usages: 3
🎁 unwrap usages: 32
🔢 array_index usages: 10
🔎 expect usages: 8

Crate: `common`

📊 Total Usages: 11

🔢 array_index usages: 1
🎁 unwrap usages: 10

Crate: `telemetry`

📊 Total Usages: 9

🔢 array_index usages: 5
🎁 unwrap usages: 4

Crate: `cloudflare_worker`

📊 Total Usages: 8

🎁 unwrap usages: 5
🚨 panic usages: 1
🔎 expect usages: 2

Crate: `engine`

📊 Total Usages: 7

🎁 unwrap usages: 6
🔎 expect usages: 1

Crate: `tracing`

📊 Total Usages: 6

🔎 expect usages: 1
🎁 unwrap usages: 5

Crate: `conductor`

📊 Total Usages: 5

🚨 panic usages: 1
🎁 unwrap usages: 1
🔎 expect usages: 3

Crate: `config`

📊 Total Usages: 3

🎁 unwrap usages: 2
🚨 panic usages: 1

📌 Expected Annotations

Crate: `engine`

📊 Total Expected Usages: 2

expand details

Reason: "if we are unable to construct the endpoints and attach them onto the gateway's http server, we have to exit"

Code: Err(e) => panic!("failed to construct endpoint: {:?}", e),
Location: ./libs/engine/src/gateway.rs:158

Reason: "we can safely index here, it's inside a test with constant defined fixtures."

Code: ConductorGateway::execute(request, &gw.routes[0].route_data).await
Location: ./libs/engine/src/gateway.rs:190

Crate: `common`

📊 Total Expected Usages: 1

expand details

Reason: "we're parsing a statically defined constant, we know it works ;)"

Code: .unwrap()
Location: ./libs/common/src/graphql.rs:31

Crate: `napi`

📊 Total Expected Usages: 1

expand details

Reason: "we need this"

Code: panic!("Exited process!")
Location: ./libs/napi/src/lib.rs:18

Crate: `vrl`

📊 Total Expected Usages: 2

expand details

Reason: "if the provided VRL code in the config file can't compile, we have to exit."

Code: panic!("failed to compile vrl program");
Location: ./plugins/vrl/src/plugin.rs:129

Reason: "states is a non-user provided variable"

Code: .expect("can't merge states when states is an empty vector!")
Location: ./plugins/vrl/src/plugin.rs:146

Crate: `cloudflare_worker`

📊 Total Expected Usages: 4

expand details

Reason: "it panics only if the header name is not valid, and we know it is."

Code: .unwrap()
Location: ./bin/cloudflare_worker/src/http_tracing.rs:20

Reason: "it panics only if the URL source is not valid, and it's already validated before."

Code: let url = req.url().unwrap();
Location: ./bin/cloudflare_worker/src/http_tracing.rs:23

Reason: "it only panics if we are not running in a CF context, should be safe."

Code: let cf_info = req.cf().unwrap();
Location: ./bin/cloudflare_worker/src/http_tracing.rs:27

Reason: "unwraps only in special cases where "data:text" is used."

Code: let http_host = url.host().unwrap().to_string();
Location: ./bin/cloudflare_worker/src/http_tracing.rs:36

Crate: `conductor`

📊 Total Expected Usages: 2

expand details

Reason: "we need to exit the process, if the logger can't be correctly set."

Code: let _guard = tracing::subscriber::set_default(subscriber);
Location: ./bin/conductor/src/lib.rs:37

Reason: "we need to exit the process, if the provided configuration file is incorrect."

Code: panic!("Failed to initialize gateway: {:?}", e);
Location: ./bin/conductor/src/lib.rs:76

Crate: `config`

📊 Total Expected Usages: 9

expand details

Reason: "👇"

Code: let raw_contents = read_to_string(file_path)
Location: ./libs/config/src/lib.rs:815

Reason: "👇"

Code: panic!("Failed to interpolate config file, please resolve the above errors");
Location: ./libs/config/src/lib.rs:847

Reason: "👇"

Code: parse_config_from_json(&config_string).expect("Failed to parse JSON config file")
Location: ./libs/config/src/lib.rs:854

Reason: "👇"

Code: parse_config_from_yaml(&config_string).expect("Failed to parse YAML config file")
Location: ./libs/config/src/lib.rs:858

Reason: "👇"

Code: _ => panic!("Unsupported config file extension"),
Location: ./libs/config/src/lib.rs:875

Reason: "👇"

Code: None => panic!("Config file has no extension"),
Location: ./libs/config/src/lib.rs:878

Reason: "statically defined regex pattern, we know it works ;)"

Code: .unwrap();
Location: ./libs/config/src/interpolate.rs:18

Reason: "part of development docgen CLI"

Code: .expect("Failed to serialize json schema for config file!");
Location: ./libs/config/src/generate-json-schema.rs:50

Reason: "part of development docgen CLI"

Code: .expect("Failed to write the json schema to the file system!");
Location: ./libs/config/src/generate-json-schema.rs:54

Crate: `jwt_auth`

📊 Total Expected Usages: 1

expand details

Reason: "if initiating an http client fails, then we have to exit."

Code: let client = wasm_polyfills::create_http_client().build().unwrap();
Location: ./plugins/jwt_auth/src/jwks_provider.rs:49

github-actions · 2024-03-26T11:57:56Z

🐋 This PR was built and pushed to the following Docker images:

Docker Bake metadata

{
"conductor": {
  "buildx.build.ref": "builder-06386b71-4178-4061-8ba1-5e217fec0f3c/builder-06386b71-4178-4061-8ba1-5e217fec0f3c0/klc98rr1ncchf04h4t330za9j",
  "containerimage.config.digest": "sha256:9f2d54a151b7a502843eab5af4dc1e6c31a518c77d71b9de41b91e9ea9115ef0",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
    "digest": "sha256:c23c2587173babde5e3f2ae093cc4e22611f8fc028ebf62cf19125712a362703",
    "size": 902,
    "platform": {
      "architecture": "amd64",
      "os": "linux"
    }
  },
  "containerimage.digest": "sha256:c23c2587173babde5e3f2ae093cc4e22611f8fc028ebf62cf19125712a362703",
  "image.name": "ghcr.io/the-guild-org/conductor/conductor:a04db700a1c8792ec118af88d6542c38b93846dc"
}
}

github-actions · 2024-03-26T11:58:30Z

✅ Benchmark Results

     data_received..................: 13 MB   221 kB/s
     data_sent......................: 22 MB   363 kB/s
     http_req_blocked...............: min=892ns    avg=2.74µs   med=2.06µs   max=2.5ms    p(95)=2.98µs   p(99)=10.43µs 
     http_req_connecting............: min=0s       avg=349ns    med=0s       max=2.47ms   p(95)=0s       p(99)=0s      
     http_req_duration..............: min=315.04µs avg=421.05µs med=379.35µs max=45.64ms  p(95)=475µs    p(99)=558.89µs
       { expected_response:true }...: min=315.04µs avg=421.05µs med=379.35µs max=45.64ms  p(95)=475µs    p(99)=558.89µs
     ✓ { scenario:rps_1000 }........: min=315.04µs avg=421.05µs med=379.35µs max=45.64ms  p(95)=475µs    p(99)=558.89µs
     http_req_failed................: 0.00%   ✓ 0          ✗ 60001
     ✓ { scenario:rps_1000 }........: 0.00%   ✓ 0          ✗ 60001
     http_req_receiving.............: min=9.99µs   avg=25.75µs  med=25.36µs  max=800.85µs p(95)=33.17µs  p(99)=39.82µs 
     http_req_sending...............: min=6.56µs   avg=15.07µs  med=13.77µs  max=1.44ms   p(95)=24.65µs  p(99)=32.32µs 
     http_req_tls_handshaking.......: min=0s       avg=0s       med=0s       max=0s       p(95)=0s       p(99)=0s      
     http_req_waiting...............: min=277.4µs  avg=380.22µs med=339.12µs max=45.58ms  p(95)=435.42µs p(99)=510.49µs
     http_reqs......................: 60001   999.995368/s
     ✓ { scenario:rps_1000 }........: 60001   999.995368/s
     iteration_duration.............: min=377.86µs avg=505.74µs med=462.96µs max=45.93ms  p(95)=562.19µs p(99)=685.3µs 
     iterations.....................: 60001   999.995368/s
     ✓ { scenario:rps_1000 }........: 60001   999.995368/s
     valid_graphql_response.........: 100.00% ✓ 60001      ✗ 0    
     ✓ { scenario:rps_1000 }........: 100.00% ✓ 60001      ✗ 0    
     valid_http_code................: 100.00% ✓ 60001      ✗ 0    
     ✓ { scenario:rps_1000 }........: 100.00% ✓ 60001      ✗ 0    
     vus............................: 1       min=0        max=2  
     vus_max........................: 200     min=200      max=200

fix(deps): update rust crate insta to 1.37.0

a04db70

dotansimha merged commit 1676eeb into master Mar 26, 2024
14 checks passed

renovate bot deleted the renovate/insta-1.x branch March 26, 2024 12:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(deps): update rust crate insta to 1.37.0 #543

fix(deps): update rust crate insta to 1.37.0 #543

renovate bot commented Mar 26, 2024

github-actions bot commented Mar 26, 2024

github-actions bot commented Mar 26, 2024

github-actions bot commented Mar 26, 2024

fix(deps): update rust crate insta to 1.37.0 #543

fix(deps): update rust crate insta to 1.37.0 #543

Conversation

renovate bot commented Mar 26, 2024

Release Notes

v1.37.0

Configuration

github-actions bot commented Mar 26, 2024

🚨 Rust Panic Audit: 102 Potential Panic Points Detected 🚨

Crate: federation_query_planner

Crate: common

Crate: telemetry

Crate: cloudflare_worker

Crate: engine

Crate: tracing

Crate: conductor

Crate: config

📌 Expected Annotations

Crate: engine

Crate: common

Crate: napi

Crate: vrl

Crate: cloudflare_worker

Crate: conductor

Crate: config

Crate: jwt_auth

github-actions bot commented Mar 26, 2024

github-actions bot commented Mar 26, 2024

✅ Benchmark Results

`v1.37.0`

Crate: `federation_query_planner`

Crate: `common`

Crate: `telemetry`

Crate: `cloudflare_worker`

Crate: `engine`

Crate: `tracing`

Crate: `conductor`

Crate: `config`

Crate: `engine`

Crate: `common`

Crate: `napi`

Crate: `vrl`

Crate: `cloudflare_worker`

Crate: `conductor`

Crate: `config`

Crate: `jwt_auth`