Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update rust crate async-trait to 0.1.79 #534

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 24, 2024

Mend Renovate

This PR contains the following updates:

Package Type Update Change
async-trait workspace.dependencies patch 0.1.78 -> 0.1.79

Release Notes

dtolnay/async-trait (async-trait)

v0.1.79

Compare Source

  • Clean up some dead code

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link

github-actions bot commented Mar 24, 2024

🚨 Rust Panic Audit: 102 Potential Panic Points Detected 🚨

Crate: federation_query_planner

📊 Total Usages: 53

  • 🚨 panic usages: 3
  • 🔢 array_index usages: 10
  • 🎁 unwrap usages: 32
  • 🔎 expect usages: 8

Crate: common

📊 Total Usages: 11

  • 🎁 unwrap usages: 10
  • 🔢 array_index usages: 1

Crate: telemetry

📊 Total Usages: 9

  • 🔢 array_index usages: 5
  • 🎁 unwrap usages: 4

Crate: cloudflare_worker

📊 Total Usages: 8

  • 🎁 unwrap usages: 5
  • 🔎 expect usages: 2
  • 🚨 panic usages: 1

Crate: engine

📊 Total Usages: 7

  • 🎁 unwrap usages: 6
  • 🔎 expect usages: 1

Crate: tracing

📊 Total Usages: 6

  • 🔎 expect usages: 1
  • 🎁 unwrap usages: 5

Crate: conductor

📊 Total Usages: 5

  • 🔎 expect usages: 3
  • 🚨 panic usages: 1
  • 🎁 unwrap usages: 1

Crate: config

📊 Total Usages: 3

  • 🎁 unwrap usages: 2
  • 🚨 panic usages: 1

📌 Expected Annotations

Crate: cloudflare_worker

📊 Total Expected Usages: 4

expand details
  1. Reason: "it panics only if the header name is not valid, and we know it is."
  • Code: .unwrap()
  • Location: ./bin/cloudflare_worker/src/http_tracing.rs:20
  1. Reason: "it panics only if the URL source is not valid, and it's already validated before."
  • Code: let url = req.url().unwrap();
  • Location: ./bin/cloudflare_worker/src/http_tracing.rs:23
  1. Reason: "it only panics if we are not running in a CF context, should be safe."
  • Code: let cf_info = req.cf().unwrap();
  • Location: ./bin/cloudflare_worker/src/http_tracing.rs:27
  1. Reason: "unwraps only in special cases where "data:text" is used."
  • Code: let http_host = url.host().unwrap().to_string();
  • Location: ./bin/cloudflare_worker/src/http_tracing.rs:36

Crate: jwt_auth

📊 Total Expected Usages: 1

expand details
  1. Reason: "if initiating an http client fails, then we have to exit."
  • Code: let client = wasm_polyfills::create_http_client().build().unwrap();
  • Location: ./plugins/jwt_auth/src/jwks_provider.rs:49

Crate: common

📊 Total Expected Usages: 1

expand details
  1. Reason: "we're parsing a statically defined constant, we know it works ;)"
  • Code: .unwrap()
  • Location: ./libs/common/src/graphql.rs:31

Crate: vrl

📊 Total Expected Usages: 2

expand details
  1. Reason: "if the provided VRL code in the config file can't compile, we have to exit."
  • Code: panic!("failed to compile vrl program");
  • Location: ./plugins/vrl/src/plugin.rs:129
  1. Reason: "states is a non-user provided variable"
  • Code: .expect("can't merge states when states is an empty vector!")
  • Location: ./plugins/vrl/src/plugin.rs:146

Crate: conductor

📊 Total Expected Usages: 2

expand details
  1. Reason: "we need to exit the process, if the logger can't be correctly set."
  • Code: let _guard = tracing::subscriber::set_default(subscriber);
  • Location: ./bin/conductor/src/lib.rs:37
  1. Reason: "we need to exit the process, if the provided configuration file is incorrect."
  • Code: panic!("Failed to initialize gateway: {:?}", e);
  • Location: ./bin/conductor/src/lib.rs:76

Crate: napi

📊 Total Expected Usages: 1

expand details
  1. Reason: "we need this"
  • Code: panic!("Exited process!")
  • Location: ./libs/napi/src/lib.rs:18

Crate: config

📊 Total Expected Usages: 9

expand details
  1. Reason: "👇"
  • Code: let raw_contents = read_to_string(file_path)
  • Location: ./libs/config/src/lib.rs:815
  1. Reason: "👇"
  • Code: panic!("Failed to interpolate config file, please resolve the above errors");
  • Location: ./libs/config/src/lib.rs:847
  1. Reason: "👇"
  • Code: parse_config_from_json(&config_string).expect("Failed to parse JSON config file")
  • Location: ./libs/config/src/lib.rs:854
  1. Reason: "👇"
  • Code: parse_config_from_yaml(&config_string).expect("Failed to parse YAML config file")
  • Location: ./libs/config/src/lib.rs:858
  1. Reason: "👇"
  • Code: _ => panic!("Unsupported config file extension"),
  • Location: ./libs/config/src/lib.rs:875
  1. Reason: "👇"
  • Code: None => panic!("Config file has no extension"),
  • Location: ./libs/config/src/lib.rs:878
  1. Reason: "statically defined regex pattern, we know it works ;)"
  • Code: .unwrap();
  • Location: ./libs/config/src/interpolate.rs:18
  1. Reason: "part of development docgen CLI"
  • Code: .expect("Failed to serialize json schema for config file!");
  • Location: ./libs/config/src/generate-json-schema.rs:50
  1. Reason: "part of development docgen CLI"
  • Code: .expect("Failed to write the json schema to the file system!");
  • Location: ./libs/config/src/generate-json-schema.rs:54

Crate: engine

📊 Total Expected Usages: 2

expand details
  1. Reason: "if we are unable to construct the endpoints and attach them onto the gateway's http server, we have to exit"
  • Code: Err(e) => panic!("failed to construct endpoint: {:?}", e),
  • Location: ./libs/engine/src/gateway.rs:158
  1. Reason: "we can safely index here, it's inside a test with constant defined fixtures."
  • Code: ConductorGateway::execute(request, &gw.routes[0].route_data).await
  • Location: ./libs/engine/src/gateway.rs:190

@renovate renovate bot force-pushed the renovate/async-trait-0.x branch from 7452c16 to 91f3445 Compare March 24, 2024 06:12
Copy link

github-actions bot commented Mar 24, 2024

🐋 This PR was built and pushed to the following Docker images:

Docker Bake metadata
{
"conductor": {
  "buildx.build.ref": "builder-ea5dc25c-d2b8-4032-b751-d834e3408114/builder-ea5dc25c-d2b8-4032-b751-d834e34081140/uawiyej8od4chysmc7h4xzrc7",
  "containerimage.config.digest": "sha256:60b222083cc990542c6aae8140dd9606407a647ac1e6ea604976dbd1750a0143",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
    "digest": "sha256:51703c906da931108bb6bb71f962ac226776bbe1dc45dc55562164d41da06476",
    "size": 902,
    "platform": {
      "architecture": "amd64",
      "os": "linux"
    }
  },
  "containerimage.digest": "sha256:51703c906da931108bb6bb71f962ac226776bbe1dc45dc55562164d41da06476",
  "image.name": "ghcr.io/the-guild-org/conductor/conductor:91f344503e030f62e817101317519c7fa280dfc3"
}
}

Copy link

github-actions bot commented Mar 24, 2024

✅ Benchmark Results

     data_received..................: 13 MB   221 kB/s
     data_sent......................: 22 MB   363 kB/s
     http_req_blocked...............: min=851ns    avg=2.71µs   med=2.06µs   max=605.34µs p(95)=3.05µs   p(99)=11.64µs 
     http_req_connecting............: min=0s       avg=322ns    med=0s       max=385.54µs p(95)=0s       p(99)=0s      
     http_req_duration..............: min=314.43µs avg=407.42µs med=381.52µs max=15.86ms  p(95)=484.09µs p(99)=567.88µs
       { expected_response:true }...: min=314.43µs avg=407.42µs med=381.52µs max=15.86ms  p(95)=484.09µs p(99)=567.88µs
     ✓ { scenario:rps_1000 }........: min=314.43µs avg=407.42µs med=381.52µs max=15.86ms  p(95)=484.09µs p(99)=567.88µs
     http_req_failed................: 0.00%   ✓ 0          ✗ 60001
     ✓ { scenario:rps_1000 }........: 0.00%   ✓ 0          ✗ 60001
     http_req_receiving.............: min=10.54µs  avg=26.21µs  med=25.74µs  max=1.32ms   p(95)=33.77µs  p(99)=40.3µs  
     http_req_sending...............: min=6.41µs   avg=14.95µs  med=13.82µs  max=818.77µs p(95)=24.04µs  p(99)=32.16µs 
     http_req_tls_handshaking.......: min=0s       avg=0s       med=0s       max=0s       p(95)=0s       p(99)=0s      
     http_req_waiting...............: min=279.37µs avg=366.25µs med=340.97µs max=15.83ms  p(95)=444.36µs p(99)=518.83µs
     http_reqs......................: 60001   999.995496/s
     ✓ { scenario:rps_1000 }........: 60001   999.995496/s
     iteration_duration.............: min=384.43µs avg=493.3µs  med=465.99µs max=16.11ms  p(95)=572.08µs p(99)=721.29µs
     iterations.....................: 60001   999.995496/s
     ✓ { scenario:rps_1000 }........: 60001   999.995496/s
     valid_graphql_response.........: 100.00% ✓ 60001      ✗ 0    
     ✓ { scenario:rps_1000 }........: 100.00% ✓ 60001      ✗ 0    
     valid_http_code................: 100.00% ✓ 60001      ✗ 0    
     ✓ { scenario:rps_1000 }........: 100.00% ✓ 60001      ✗ 0    
     vus............................: 1       min=0        max=2  
     vus_max........................: 200     min=200      max=200

@dotansimha dotansimha merged commit aa25d98 into master Mar 25, 2024
14 checks passed
@renovate renovate bot deleted the renovate/async-trait-0.x branch March 25, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant