fix(deps): update rust crate serde_yaml to 0.9.33 #514

renovate · 2024-03-17T08:05:58Z

This PR contains the following updates:

Package	Type	Update	Change
serde_yaml	dependencies	patch	`0.9.32` -> `0.9.33`

Release Notes

dtolnay/serde-yaml (serde_yaml)

`v0.9.33`

Compare Source

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

github-actions · 2024-03-17T08:06:40Z

🚨 Rust Panic Audit: 87 Potential Panic Points Detected 🚨

Crate: `federation_query_planner`

📊 Total Usages: 51

🚨 panic usages: 3
🔎 expect usages: 8
🎁 unwrap usages: 30
🔢 array_index usages: 10

Crate: `engine`

📊 Total Usages: 11

🔎 expect usages: 1
🎁 unwrap usages: 7
🚨 panic usages: 3

Crate: `telemetry`

📊 Total Usages: 9

🔢 array_index usages: 5
🎁 unwrap usages: 4

Crate: `cloudflare_worker`

📊 Total Usages: 6

🚨 panic usages: 1
🎁 unwrap usages: 5

Crate: `tracing`

📊 Total Usages: 6

🎁 unwrap usages: 5
🔎 expect usages: 1

Crate: `conductor`

📊 Total Usages: 3

🎁 unwrap usages: 1
🔎 expect usages: 1
🚨 panic usages: 1

Crate: `config`

📊 Total Usages: 1

🚨 panic usages: 1

📌 Expected Annotations

Crate: `engine`

📊 Total Expected Usages: 5

expand details

Reason: "if we are unable to construct the endpoints and attach them onto the gateway's http server, we have to exit"

Code: Err(e) => panic!("failed to construct endpoint: {:?}", e),
Location: ./libs/engine/src/gateway.rs:147

Reason: "we can safely index here, it's inside a test with constant defined fixtures."

Code: ConductorGateway::execute(request, &gw.routes[0].route_data).await
Location: ./libs/engine/src/gateway.rs:179

Reason: "without a fetcher, there's no executor, without an executor, there's no gateway."

Code: panic!(
Location: ./libs/engine/src/source/graphql_source.rs:30

Reason: "without a fetcher, there's no executor, without an executor, there's no gateway."

Code: panic!("Failed while initializing the executor's fetcher for Federation source");
Location: ./libs/engine/src/source/federation_source.rs:111

Reason: "without a fetcher, there's no executor, without an executor, there's no gateway."

Code: panic!("Failed while initializing the executor's fetcher for Federation source");
Location: ./libs/engine/src/source/federation_source.rs:142

Crate: `common`

📊 Total Expected Usages: 1

expand details

Reason: "we're parsing a statically defined constant, we know it works ;)"

Code: .unwrap()
Location: ./libs/common/src/graphql.rs:23

Crate: `conductor`

📊 Total Expected Usages: 2

expand details

Reason: "we need to exit the process, if the logger can't be correctly set."

Code: tracing::subscriber::set_global_default(subscriber).expect("failed to set up tracing");
Location: ./bin/conductor/src/lib.rs:37

Reason: "we need to exit the process, if the provided configuration file is incorrect."

Code: panic!("Failed to initialize gateway: {:?}", e);
Location: ./bin/conductor/src/lib.rs:76

Crate: `jwt_auth`

📊 Total Expected Usages: 1

expand details

Reason: "if initiating an http client fails, then we have to exit."

Code: let client = wasm_polyfills::create_http_client().build().unwrap();
Location: ./plugins/jwt_auth/src/jwks_provider.rs:49

Crate: `cloudflare_worker`

📊 Total Expected Usages: 4

expand details

Reason: "it panics only if the header name is not valid, and we know it is."

Code: .unwrap()
Location: ./bin/cloudflare_worker/src/http_tracing.rs:20

Reason: "it panics only if the URL source is not valid, and it's already validated before."

Code: let url = req.url().unwrap();
Location: ./bin/cloudflare_worker/src/http_tracing.rs:23

Reason: "it only panics if we are not running in a CF context, should be safe."

Code: let cf_info = req.cf().unwrap();
Location: ./bin/cloudflare_worker/src/http_tracing.rs:27

Reason: "unwraps only in special cases where "data:text" is used."

Code: let http_host = url.host().unwrap().to_string();
Location: ./bin/cloudflare_worker/src/http_tracing.rs:36

Crate: `napi`

📊 Total Expected Usages: 1

expand details

Reason: "we need this"

Code: panic!("Exited process!")
Location: ./libs/napi/src/lib.rs:18

Crate: `config`

📊 Total Expected Usages: 9

expand details

Reason: "👇"

Code: let raw_contents = read_to_string(file_path)
Location: ./libs/config/src/lib.rs:597

Reason: "👇"

Code: panic!("Failed to interpolate config file, please resolve the above errors");
Location: ./libs/config/src/lib.rs:629

Reason: "👇"

Code: parse_config_from_json(&config_string).expect("Failed to parse JSON config file")
Location: ./libs/config/src/lib.rs:636

Reason: "👇"

Code: parse_config_from_yaml(&config_string).expect("Failed to parse YAML config file")
Location: ./libs/config/src/lib.rs:640

Reason: "👇"

Code: _ => panic!("Unsupported config file extension"),
Location: ./libs/config/src/lib.rs:657

Reason: "👇"

Code: None => panic!("Config file has no extension"),
Location: ./libs/config/src/lib.rs:660

Reason: "statically defined regex pattern, we know it works ;)"

Code: .unwrap();
Location: ./libs/config/src/interpolate.rs:18

Reason: "part of development docgen CLI"

Code: .expect("Failed to serialize json schema for config file!");
Location: ./libs/config/src/generate-json-schema.rs:50

Reason: "part of development docgen CLI"

Code: .expect("Failed to write the json schema to the file system!");
Location: ./libs/config/src/generate-json-schema.rs:54

Crate: `vrl`

📊 Total Expected Usages: 2

expand details

Reason: "if the provided VRL code in the config file can't compile, we have to exit."

Code: panic!("failed to compile vrl program");
Location: ./plugins/vrl/src/plugin.rs:122

Reason: "states is a non-user provided variable"

Code: .expect("can't merge states when states is an empty vector!")
Location: ./plugins/vrl/src/plugin.rs:139

github-actions · 2024-03-17T08:14:35Z

🐋 This PR was built and pushed to the following Docker images:

Docker Bake metadata

{
"conductor": {
  "buildx.build.ref": "builder-d923fb4c-f03e-42f5-b803-fea61339c3ab/builder-d923fb4c-f03e-42f5-b803-fea61339c3ab0/qjmlutzn8i363qdym84w5aprt",
  "containerimage.config.digest": "sha256:5e150dbe8a08a8ec6df676f4f5f0f57f6387e70e7ed9b83bf209af67d1867903",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
    "digest": "sha256:418722ea804fa7618e3691c71fcfeec9442e63494ef16325783b7dac0c2af7b1",
    "size": 902,
    "platform": {
      "architecture": "amd64",
      "os": "linux"
    }
  },
  "containerimage.digest": "sha256:418722ea804fa7618e3691c71fcfeec9442e63494ef16325783b7dac0c2af7b1",
  "image.name": "ghcr.io/the-guild-org/conductor/conductor:9010d6efdacc3bc3b2ff3e95a969b56a165d697b"
}
}

github-actions · 2024-03-17T08:15:13Z

✅ Benchmark Results

     data_received..................: 13 MB   221 kB/s
     data_sent......................: 22 MB   363 kB/s
     http_req_blocked...............: min=721ns    avg=2.49µs   med=1.9µs    max=516.98µs p(95)=2.83µs   p(99)=6.11µs  
     http_req_connecting............: min=0s       avg=306ns    med=0s       max=399.8µs  p(95)=0s       p(99)=0s      
     http_req_duration..............: min=310.88µs avg=403.43µs med=379.4µs  max=20.6ms   p(95)=468.88µs p(99)=535.76µs
       { expected_response:true }...: min=310.88µs avg=403.43µs med=379.4µs  max=20.6ms   p(95)=468.88µs p(99)=535.76µs
     ✓ { scenario:rps_1000 }........: min=310.88µs avg=403.43µs med=379.4µs  max=20.6ms   p(95)=468.88µs p(99)=535.76µs
     http_req_failed................: 0.00%   ✓ 0          ✗ 60001
     ✓ { scenario:rps_1000 }........: 0.00%   ✓ 0          ✗ 60001
     http_req_receiving.............: min=9.93µs   avg=25.57µs  med=25.15µs  max=1.05ms   p(95)=33.51µs  p(99)=42.64µs 
     http_req_sending...............: min=6.18µs   avg=14.74µs  med=13.52µs  max=1.4ms    p(95)=23.2µs   p(99)=31.63µs 
     http_req_tls_handshaking.......: min=0s       avg=0s       med=0s       max=0s       p(95)=0s       p(99)=0s      
     http_req_waiting...............: min=274.14µs avg=363.11µs med=339.65µs max=20.55ms  p(95)=429.87µs p(99)=491.11µs
     http_reqs......................: 60001   999.990324/s
     ✓ { scenario:rps_1000 }........: 60001   999.990324/s
     iteration_duration.............: min=380.85µs avg=487.48µs med=462.49µs max=20.83ms  p(95)=554.45µs p(99)=658.05µs
     iterations.....................: 60001   999.990324/s
     ✓ { scenario:rps_1000 }........: 60001   999.990324/s
     valid_graphql_response.........: 100.00% ✓ 60001      ✗ 0    
     ✓ { scenario:rps_1000 }........: 100.00% ✓ 60001      ✗ 0    
     valid_http_code................: 100.00% ✓ 60001      ✗ 0    
     ✓ { scenario:rps_1000 }........: 100.00% ✓ 60001      ✗ 0    
     vus............................: 0       min=0        max=2  
     vus_max........................: 200     min=200      max=200

fix(deps): update rust crate serde_yaml to 0.9.33

9010d6e

dotansimha merged commit ed95aa6 into master Mar 17, 2024
14 checks passed

renovate bot deleted the renovate/serde_yaml-0.x branch March 17, 2024 12:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(deps): update rust crate serde_yaml to 0.9.33 #514

fix(deps): update rust crate serde_yaml to 0.9.33 #514

renovate bot commented Mar 17, 2024

github-actions bot commented Mar 17, 2024

github-actions bot commented Mar 17, 2024

github-actions bot commented Mar 17, 2024

fix(deps): update rust crate serde_yaml to 0.9.33 #514

fix(deps): update rust crate serde_yaml to 0.9.33 #514

Conversation

renovate bot commented Mar 17, 2024

Release Notes

v0.9.33

Configuration

github-actions bot commented Mar 17, 2024

🚨 Rust Panic Audit: 87 Potential Panic Points Detected 🚨

Crate: federation_query_planner

Crate: engine

Crate: telemetry

Crate: cloudflare_worker

Crate: tracing

Crate: conductor

Crate: config

📌 Expected Annotations

Crate: engine

Crate: common

Crate: conductor

Crate: jwt_auth

Crate: cloudflare_worker

Crate: napi

Crate: config

Crate: vrl

github-actions bot commented Mar 17, 2024

github-actions bot commented Mar 17, 2024

✅ Benchmark Results

`v0.9.33`

Crate: `federation_query_planner`

Crate: `engine`

Crate: `telemetry`

Crate: `cloudflare_worker`

Crate: `tracing`

Crate: `conductor`

Crate: `config`

Crate: `engine`

Crate: `common`

Crate: `conductor`

Crate: `jwt_auth`

Crate: `cloudflare_worker`

Crate: `napi`

Crate: `config`

Crate: `vrl`