Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update rust crate reqwest-middleware to 0.2.5 #512

Merged
merged 1 commit into from
Mar 17, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 15, 2024

Mend Renovate

This PR contains the following updates:

Package Type Update Change
reqwest-middleware workspace.dependencies patch 0.2.4 -> 0.2.5

Release Notes

TrueLayer/reqwest-middleware (reqwest-middleware)

v0.2.5


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link

🚨 Rust Panic Audit: 87 Potential Panic Points Detected 🚨

Crate: federation_query_planner

📊 Total Usages: 51

  • 🎁 unwrap usages: 30
  • 🚨 panic usages: 3
  • 🔢 array_index usages: 10
  • 🔎 expect usages: 8

Crate: engine

📊 Total Usages: 11

  • 🔎 expect usages: 1
  • 🎁 unwrap usages: 7
  • 🚨 panic usages: 3

Crate: telemetry

📊 Total Usages: 9

  • 🔢 array_index usages: 5
  • 🎁 unwrap usages: 4

Crate: tracing

📊 Total Usages: 6

  • 🔎 expect usages: 1
  • 🎁 unwrap usages: 5

Crate: cloudflare_worker

📊 Total Usages: 6

  • 🎁 unwrap usages: 5
  • 🚨 panic usages: 1

Crate: conductor

📊 Total Usages: 3

  • 🔎 expect usages: 1
  • 🎁 unwrap usages: 1
  • 🚨 panic usages: 1

Crate: config

📊 Total Usages: 1

  • 🚨 panic usages: 1

📌 Expected Annotations

Crate: vrl

📊 Total Expected Usages: 2

expand details
  1. Reason: "if the provided VRL code in the config file can't compile, we have to exit."
  • Code: panic!("failed to compile vrl program");
  • Location: ./plugins/vrl/src/plugin.rs:122
  1. Reason: "states is a non-user provided variable"
  • Code: .expect("can't merge states when states is an empty vector!")
  • Location: ./plugins/vrl/src/plugin.rs:139

Crate: jwt_auth

📊 Total Expected Usages: 1

expand details
  1. Reason: "if initiating an http client fails, then we have to exit."
  • Code: let client = wasm_polyfills::create_http_client().build().unwrap();
  • Location: ./plugins/jwt_auth/src/jwks_provider.rs:49

Crate: common

📊 Total Expected Usages: 1

expand details
  1. Reason: "we're parsing a statically defined constant, we know it works ;)"
  • Code: .unwrap()
  • Location: ./libs/common/src/graphql.rs:23

Crate: engine

📊 Total Expected Usages: 5

expand details
  1. Reason: "if we are unable to construct the endpoints and attach them onto the gateway's http server, we have to exit"
  • Code: Err(e) => panic!("failed to construct endpoint: {:?}", e),
  • Location: ./libs/engine/src/gateway.rs:147
  1. Reason: "we can safely index here, it's inside a test with constant defined fixtures."
  • Code: ConductorGateway::execute(request, &gw.routes[0].route_data).await
  • Location: ./libs/engine/src/gateway.rs:179
  1. Reason: "without a fetcher, there's no executor, without an executor, there's no gateway."
  • Code: panic!(
  • Location: ./libs/engine/src/source/graphql_source.rs:30
  1. Reason: "without a fetcher, there's no executor, without an executor, there's no gateway."
  • Code: panic!("Failed while initializing the executor's fetcher for Federation source");
  • Location: ./libs/engine/src/source/federation_source.rs:111
  1. Reason: "without a fetcher, there's no executor, without an executor, there's no gateway."
  • Code: panic!("Failed while initializing the executor's fetcher for Federation source");
  • Location: ./libs/engine/src/source/federation_source.rs:142

Crate: napi

📊 Total Expected Usages: 1

expand details
  1. Reason: "we need this"
  • Code: panic!("Exited process!")
  • Location: ./libs/napi/src/lib.rs:18

Crate: config

📊 Total Expected Usages: 9

expand details
  1. Reason: "👇"
  • Code: let raw_contents = read_to_string(file_path)
  • Location: ./libs/config/src/lib.rs:597
  1. Reason: "👇"
  • Code: panic!("Failed to interpolate config file, please resolve the above errors");
  • Location: ./libs/config/src/lib.rs:629
  1. Reason: "👇"
  • Code: parse_config_from_json(&config_string).expect("Failed to parse JSON config file")
  • Location: ./libs/config/src/lib.rs:636
  1. Reason: "👇"
  • Code: parse_config_from_yaml(&config_string).expect("Failed to parse YAML config file")
  • Location: ./libs/config/src/lib.rs:640
  1. Reason: "👇"
  • Code: _ => panic!("Unsupported config file extension"),
  • Location: ./libs/config/src/lib.rs:657
  1. Reason: "👇"
  • Code: None => panic!("Config file has no extension"),
  • Location: ./libs/config/src/lib.rs:660
  1. Reason: "statically defined regex pattern, we know it works ;)"
  • Code: .unwrap();
  • Location: ./libs/config/src/interpolate.rs:18
  1. Reason: "part of development docgen CLI"
  • Code: .expect("Failed to serialize json schema for config file!");
  • Location: ./libs/config/src/generate-json-schema.rs:50
  1. Reason: "part of development docgen CLI"
  • Code: .expect("Failed to write the json schema to the file system!");
  • Location: ./libs/config/src/generate-json-schema.rs:54

Crate: conductor

📊 Total Expected Usages: 2

expand details
  1. Reason: "we need to exit the process, if the logger can't be correctly set."
  • Code: tracing::subscriber::set_global_default(subscriber).expect("failed to set up tracing");
  • Location: ./bin/conductor/src/lib.rs:37
  1. Reason: "we need to exit the process, if the provided configuration file is incorrect."
  • Code: panic!("Failed to initialize gateway: {:?}", e);
  • Location: ./bin/conductor/src/lib.rs:76

Crate: cloudflare_worker

📊 Total Expected Usages: 4

expand details
  1. Reason: "it panics only if the header name is not valid, and we know it is."
  • Code: .unwrap()
  • Location: ./bin/cloudflare_worker/src/http_tracing.rs:20
  1. Reason: "it panics only if the URL source is not valid, and it's already validated before."
  • Code: let url = req.url().unwrap();
  • Location: ./bin/cloudflare_worker/src/http_tracing.rs:23
  1. Reason: "it only panics if we are not running in a CF context, should be safe."
  • Code: let cf_info = req.cf().unwrap();
  • Location: ./bin/cloudflare_worker/src/http_tracing.rs:27
  1. Reason: "unwraps only in special cases where "data:text" is used."
  • Code: let http_host = url.host().unwrap().to_string();
  • Location: ./bin/cloudflare_worker/src/http_tracing.rs:36

Copy link

🐋 This PR was built and pushed to the following Docker images:

Docker Bake metadata
{
"conductor": {
  "buildx.build.ref": "builder-f5803262-4bf2-4654-afe9-310dc0f57940/builder-f5803262-4bf2-4654-afe9-310dc0f579400/yar6oj45ctptgv3pq4jn86l6n",
  "containerimage.config.digest": "sha256:17aefb03357fcd136d4956768ddaef4ae0fbf0a43edb05450a42f6ceb161b971",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
    "digest": "sha256:9417c61922fffd79479bd1392cd48684cfa5e97946a0532149cd8793af6e9608",
    "size": 902,
    "platform": {
      "architecture": "amd64",
      "os": "linux"
    }
  },
  "containerimage.digest": "sha256:9417c61922fffd79479bd1392cd48684cfa5e97946a0532149cd8793af6e9608",
  "image.name": "ghcr.io/the-guild-org/conductor/conductor:cd0e5be51a27999b91f47fbb8241b6cda81b8528"
}
}

Copy link

✅ Benchmark Results

     data_received..................: 13 MB   221 kB/s
     data_sent......................: 22 MB   363 kB/s
     http_req_blocked...............: min=622ns    avg=2.19µs   med=1.56µs   max=864.86µs p(95)=2.42µs   p(99)=4.14µs  
     http_req_connecting............: min=0s       avg=323ns    med=0s       max=805.48µs p(95)=0s       p(99)=0s      
     http_req_duration..............: min=292µs    avg=402.63µs med=377.07µs max=27.05ms  p(95)=456.16µs p(99)=527.38µs
       { expected_response:true }...: min=292µs    avg=402.63µs med=377.07µs max=27.05ms  p(95)=456.16µs p(99)=527.38µs
     ✓ { scenario:rps_1000 }........: min=292µs    avg=402.63µs med=377.07µs max=27.05ms  p(95)=456.16µs p(99)=527.38µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 60001
     ✓ { scenario:rps_1000 }........: 0.00%   ✓ 0           ✗ 60001
     http_req_receiving.............: min=8.88µs   avg=25.41µs  med=25.12µs  max=1.27ms   p(95)=32.61µs  p(99)=38.44µs 
     http_req_sending...............: min=5.58µs   avg=14.47µs  med=13.03µs  max=3.49ms   p(95)=24.98µs  p(99)=33.39µs 
     http_req_tls_handshaking.......: min=0s       avg=0s       med=0s       max=0s       p(95)=0s       p(99)=0s      
     http_req_waiting...............: min=262.89µs avg=362.75µs med=337.55µs max=27ms     p(95)=418.77µs p(99)=484.56µs
     http_reqs......................: 60001   1000.002924/s
     ✓ { scenario:rps_1000 }........: 60001   1000.002924/s
     iteration_duration.............: min=357.9µs  avg=483.4µs  med=456.79µs max=27.28ms  p(95)=539.83µs p(99)=655.03µs
     iterations.....................: 60001   1000.002924/s
     ✓ { scenario:rps_1000 }........: 60001   1000.002924/s
     valid_graphql_response.........: 100.00% ✓ 60001       ✗ 0    
     ✓ { scenario:rps_1000 }........: 100.00% ✓ 60001       ✗ 0    
     valid_http_code................: 100.00% ✓ 60001       ✗ 0    
     ✓ { scenario:rps_1000 }........: 100.00% ✓ 60001       ✗ 0    
     vus............................: 0       min=0         max=2  
     vus_max........................: 200     min=200       max=200

@dotansimha dotansimha merged commit 6fdaa6d into master Mar 17, 2024
14 checks passed
@renovate renovate bot deleted the renovate/reqwest-middleware-0.x branch March 17, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant