Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set exit code only on validation errors #62

Merged
merged 1 commit into from
Dec 7, 2021
Merged

fix: set exit code only on validation errors #62

merged 1 commit into from
Dec 7, 2021

Conversation

micalevisk
Copy link
Contributor

closes #57

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 7, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@olavoparno olavoparno merged commit 9526070 into the-bugging:develop Dec 7, 2021
@micalevisk
Copy link
Contributor Author

@olavoparno I just fixed the unit test that was wrong in https://github.com/micalevisk/istanbul-badges-readme/commit/a56d2b9561ddc72e59aaf81b166fe403e74b8631

@olavoparno
Copy link
Member

@micalevisk I was too anxious and I merged it already. I liked the assertion against the very method of getting the error code but it also should be in the catch phase haha, sorry I didn't see it before ><

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature request: exit with non-zero code upon validation errors
2 participants
@micalevisk @olavoparno