fix: check for read & write permissions on README file #59

micalevisk · 2021-11-24T23:42:03Z

Closes #58

For whatever reason doing:

try {
  fs.accessSync('fake-path', fs.constants.R_OK | fs.constants.W_OK)
} catch (err) {
  console.log(err instanceof Error) // always: false
}

in some spec file, err above won't be an instance of Error. This is why I've use mockImplementation on fs.accessSync method. Otherwise, it never enter on the IF statement of L19 of src/validate.ts

I didn't like that approach as it doesn't use the real fs module, and makes the test suite pretty coupled with the implementation. But didn't find another way to write that.