How long has THIS been broken?

the-blank-x · Jul 23, 2021 · 48fc10d · 48fc10d
1 parent d50fd37
commit 48fc10d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/build/actions.js b/build/actions.js
@@ -39,6 +39,9 @@ const actions = {
   },
 
   async write ({ output, content, duplicate }) {
+    if (!content) {
+      throw new TypeError('Got an empty write?' + output);
+    }
     output = resolve(output);
     await fs.ensureDir(path.dirname(output));
     await fs.writeFile(output, content);

diff --git a/build/evaluate.js b/build/evaluate.js
@@ -53,7 +53,7 @@ module.exports = exports = async function process (tasks, cache) {
     }
     if (taskLog && LOG[taskLog[0]]) log.info(...taskLog);
 
-    if (cache.isProd) {
+    if (cache.isProd && status.revPath) {
       await fs.writeFile(resolve('dist', status.revPath), result);
     }
 

diff --git a/build/scripts.js b/build/scripts.js
@@ -74,7 +74,7 @@ class ClientScript extends File {
     let contents = await Promise.map(files, readFile);
     contents = contents.join('\n\n');
     if (prod) {
-      const { code, error } = minify(contents, { output: { comments: false } });
+      const { code, error } = await minify(contents, { output: { comments: false } });
       if (error) throw new Error(error);
       contents = code;
     }