Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pm2 to start durian.js #8072

Closed
wants to merge 0 commits into from

Conversation

mario-huang
Copy link
Contributor

pm2-beta seams support bun now, I want to try. If it works, then all bun apps can use it.

@waghanza
Copy link
Collaborator

Does this version of pm2 can use deno also ?

@mario-huang
Copy link
Contributor Author

Does this version of pm2 can use deno also ?

no, but deno has alternative to pm2 - Pup
https://deno.land/x/pup

@mario-huang
Copy link
Contributor Author

need help:

Run bundle exec rake config
rake aborted!
NoMethodError: undefined method `unshift' for an instance of String (NoMethodError)

    value.unshift(*value2)
         ^^^^^^^^

/home/runner/work/web-frameworks/web-frameworks/Rakefile:80:in override_or_merge' /home/runner/work/web-frameworks/web-frameworks/Rakefile:69:in block in custom_config'
/home/runner/work/web-frameworks/web-frameworks/Rakefile:66:in each' /home/runner/work/web-frameworks/web-frameworks/Rakefile:66:in custom_config'
/home/runner/work/web-frameworks/web-frameworks/Rakefile:225:in block ([4](https://github.com/the-benchmarker/web-frameworks/actions/runs/12480482397/job/34831395013?pr=8072#step:6:5) levels) in <top (required)>' /home/runner/work/web-frameworks/web-frameworks/Rakefile:224:in each'
/home/runner/work/web-frameworks/web-frameworks/Rakefile:224:in block (3 levels) in <top (required)>' /home/runner/work/web-frameworks/web-frameworks/Rakefile:223:in each'
/home/runner/work/web-frameworks/web-frameworks/Rakefile:223:in block (2 levels) in <top (required)>' /home/runner/work/web-frameworks/web-frameworks/Rakefile:217:in each'
/home/runner/work/web-frameworks/web-frameworks/Rakefile:217:in block in <top (required)>' /home/runner/work/web-frameworks/web-frameworks/vendor/bundle/ruby/3.3.0/gems/rake-13.2.1/exe/rake:27:in <top (required)>'
/opt/hostedtoolcache/Ruby/3.3.6/x64/bin/bundle:25:in load' /opt/hostedtoolcache/Ruby/3.3.6/x64/bin/bundle:25:in

'
Tasks: TOP => config
(See full trace by running task with --trace)
Error: Process completed with exit code 1.

@waghanza
Copy link
Collaborator

Will be great to have pup then for deno and pm2 for both bun and node

@waghanza
Copy link
Collaborator

Last time I've check pup was not production-ready

Copy link
Collaborator

@waghanza waghanza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion made will fix CI 😇

Could you also remove bootstrap option in durians config file, and change the one in javascript/config.yaml to bun install --production, in order to make sure Dev dependencies are not use (and to compute build time, in the future)

@@ -5,3 +5,5 @@ framework:
- bun
bootstrap:
- bun install
command:
- bun run pm2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a string, not an array.

Also this should be set in javascript/config.yaml file

@mario-huang
Copy link
Contributor Author

Suggestion made will fix CI 😇

Could you also remove bootstrap option in durians config file, and change the one in javascript/config.yaml to bun install --production, in order to make sure Dev dependencies are not use (and to compute build time, in the future)

done that~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants