refactor (.NET) : Simplify-dotnet-projects #6803
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update config.yaml
ShreyasJejurkar
changed the title
waghanza
reviewed
Oct 8, 2023
csharp/Dockerfile
Outdated
| @@ -4,6 +4,7 @@ WORKDIR /usr/src/app | |||
|
|
|||
| # copy csproj and restore as distinct layers | |||
| COPY *.csproj . | |||
| COPY Directory.Build.props . | |||
There was a problem hiding this comment.
not sure it will work, docker root directoy is csharp/carter not csharp
There was a problem hiding this comment.
why its set to csharp/carter? hmm, how do I achieve this now?
There was a problem hiding this comment.
I did ../Directory.build.props but still does not work. any idea?
There was a problem hiding this comment.
the easyiest way to do the trick @ShreyasJejurkar is, imho, to use symlinks (create main file is csharp, and create symlinks in all frameworks directory)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.