-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update results #4896
Update results #4896
Conversation
some components ( - Downloading symfony/http-foundation (v6.0.0)
- Downloading symfony/event-dispatcher-contracts (v2.5.0)
- Downloading symfony/event-dispatcher (v6.0.0)
- Downloading symfony/var-dumper (v6.0.0)
- Downloading symfony/error-handler (v6.0.0)
- Downloading symfony/http-kernel (v5.4.0) is it intended ? |
@beetlex-io https://github.com/the-benchmarker/web-frameworks/runs/4443471017?check_suite_focus=true @amirfaramarzi there is a breaking change for tower in https://github.com/the-benchmarker/web-frameworks/runs/4443483689?check_suite_focus=true#step:6:2194. I think it might be a good idea to |
hi @waghanza And if you still need to change the version of the tower, send a message |
Hi @amirfaramarzi, The point is that the php version required was changed (by a minor) is the same major of your framework, and then a major contains a breaking change. With this change a user of |
The tower version changed to 1.17.0 |
3e13f5d
to
43b4a0f
Compare
Imo it will be better exclude failing frameworks and add a require fix label on the website so scheduled results don't effected. |
Yeah, I plan to do this if I can not publish results / fix those frameworks for sunday |
The version of http4k is waaaaaaaay out of date so am not surprised it doesn’t work. 4.17.3.0 is the latest.
…On 18 Dec 2021, 13:32 +0000, Marwan Rabbâa ***@***.***>, wrote:
Failing frameworks
• beetlex https://github.com/the-benchmarker/web-frameworks/runs/4569461904?check_suite_focus=true
• http4k https://github.com/the-benchmarker/web-frameworks/runs/4569463640?check_suite_focus=true
• scorper https://github.com/the-benchmarker/web-frameworks/runs/4569463791?check_suite_focus=true
@daviddenton @s4nchez @bung87 @beetlex-io Any help will be ❤️
You can view, comment on, or merge this pull request online at:
#4896
Commit Summary
• fcc32a9 update results
• 94e9000 update results
• e165c4b use sf 5.x with driftphp
• 621d839 update results
• c2e0fc5 update results
• 34217d8 update results
• 7900508 downgrade tower
• 3509710 beautify
• da18b22 fix ktor
File Changes
(7 files)
• M data.json (19881)
• M data.min.json (2)
• M kotlin/ktor/build.gradle (5)
• M php/driftphp/composer.json (2)
• M php/tower/composer.json (2)
• M php/tower/config.yaml (2)
• M ruby/agoo/app.rb (2)
Patch Links:
• https://github.com/the-benchmarker/web-frameworks/pull/4896.patch
• https://github.com/the-benchmarker/web-frameworks/pull/4896.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Thanks @daviddenton, having an outdated version couldn’t help, indeed (it should have been caught by If you have time to create a new implementation, it will be very appreciated |
you should just be able to drop the new version in and it will work ok :)
…On 18 Dec 2021, 13:48 +0000, Marwan Rabbâa ***@***.***>, wrote:
Thanks @daviddenton, having an outdated version couldn’t help, indeed (it should have been caught by renovatebot btw)
If you have time to create a new implementation, it will be very appreciated
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This
PR
updates resultsFailing frameworks
grape
Load error with active_support 7 ruby-grape/grape#2205 ℹ️ use masterTo run again
bunrouter