Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update results #4896

Merged
merged 11 commits into from
Dec 23, 2021
Merged

Update results #4896

merged 11 commits into from
Dec 23, 2021

Conversation

waghanza
Copy link
Collaborator

@waghanza waghanza commented Dec 3, 2021

This PR updates results

Failing frameworks

To run again

  • bunrouter

@waghanza
Copy link
Collaborator Author

waghanza commented Dec 3, 2021

@waghanza
Copy link
Collaborator Author

waghanza commented Dec 4, 2021

some components (symfony based) are not on the same major

  - Downloading symfony/http-foundation (v6.0.0)
  - Downloading symfony/event-dispatcher-contracts (v2.5.0)
  - Downloading symfony/event-dispatcher (v6.0.0)
  - Downloading symfony/var-dumper (v6.0.0)
  - Downloading symfony/error-handler (v6.0.0)
  - Downloading symfony/http-kernel (v5.4.0)

is it intended ?

@waghanza
Copy link
Collaborator Author

waghanza commented Dec 7, 2021

@amirfaramarzi
Copy link
Contributor

hi @waghanza
This error is because your computer does not support php 8.1
Please upgrade your php version
And if possible, check that jit and opcache are enabled via the phpinfo function

And if you still need to change the version of the tower, send a message
Thanks

@waghanza
Copy link
Collaborator Author

waghanza commented Dec 8, 2021

Hi @amirfaramarzi,

The point is that the php version required was changed (by a minor) is the same major of your framework, and then a major contains a breaking change.

With this change a user of tower (with a constraint like ^1.16.0 or ~1.16.0) could break due to version change, its a common practice to upgrade major in such a case

@amirfaramarzi
Copy link
Contributor

@waghanza

The tower version changed to 1.17.0

@waghanza waghanza force-pushed the update branch 3 times, most recently from 3e13f5d to 43b4a0f Compare December 13, 2021 05:50
@waghanza
Copy link
Collaborator Author

@waghanza waghanza changed the title Update results on 3rd of december 2021 Update result Dec 13, 2021
@waghanza waghanza changed the title Update result Update results Dec 13, 2021
@waghanza
Copy link
Collaborator Author

@Willyboar
Copy link
Contributor

Imo it will be better exclude failing frameworks and add a require fix label on the website so scheduled results don't effected.

@waghanza
Copy link
Collaborator Author

Yeah, I plan to do this if I can not publish results / fix those frameworks for sunday

@waghanza waghanza closed this Dec 17, 2021
@waghanza waghanza reopened this Dec 17, 2021
@daviddenton
Copy link
Contributor

daviddenton commented Dec 18, 2021 via email

@waghanza
Copy link
Collaborator Author

Thanks @daviddenton, having an outdated version couldn’t help, indeed (it should have been caught by renovatebot btw)

If you have time to create a new implementation, it will be very appreciated

@daviddenton
Copy link
Contributor

daviddenton commented Dec 18, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants