[PHP] Upgrade to 8.0

[waghanza]

Hi,

This PR replaces #3606, it upgrade PHP to 8.0

Regards,

[waghanza]

@dominikzogg seems that a dependency of yours is not PHP 8 compatible
https://the-benchmarker.semaphoreci.com/jobs/140d85e3-528c-4227-b829-195cae815911 in https://github.com/chubbyphp/chubbyphp-swoole-request-handler/blob/af4e8c91e9897fa49e0e530b188daa22c26e814f/composer.json#L22

[dominikzogg]

@waghanza as i can see, you already saw the open PR: dflydev/dflydev-fig-cookies#39

[dominikzogg]

@waghanza the dependency that was not ready for php 8 (dflydev/dflydev-fig-cookies) is ready now, means the chubbyphp-swoole and slim-swoole should run on php8

[waghanza]

let see what's CI say

[dominikzogg]

@waghanza it seems that the newly added libevent does not work (all workerman stuff fails)

[waghanza]

You mean event php module configured in

web-frameworks/php/chubbyphp-workerman/config.yaml

Line 1 in eb5479f

framework:

I though this module was required on production

[dominikzogg]

@waghanza it's much better with the extension (from what I read) but it seems to fail compiling

[waghanza]

@waghanza it's much better with the extension (from what I read) but it seems to fail compiling

And idea @walkor ?

As I can see event has php8 support https://pecl.php.net/package-changelog.php?package=event&release=3.0.2

@dominikzogg see that an outdate version of event is used https://github.com/the-benchmarker/web-frameworks/runs/1753805064?check_suite_focus=true#step:6:975, I'll open an issue

[laylatichy]

@waghanza it's much better with the extension (from what I read) but it seems to fail compiling

And idea @walkor ?

As I can see event has php8 support https://pecl.php.net/package-changelog.php?package=event&release=3.0.2

@dominikzogg see that an outdate version of event is used https://github.com/the-benchmarker/web-frameworks/runs/1753805064?check_suite_focus=true#step:6:975, I'll open an issue

@waghanza pecl and pear are not available in php8 by default - see https://externals.io/message/103977

instead of pecl install xxx you have to run

mkdir -p /usr/src/php/ext/xxx && curl -fsSL https://pecl.php.net/get/xxx | tar xvz -C "/usr/src/php/ext/xxx" --strip 1 && docker-php-ext-install xxx \

[waghanza]

pecl and pear are not available in php8

However I have access to this command on php8 containers

@dominikzogg Having an non-compatible extension is 🆗 since PHP 8 event is still in beta. We have to wait

[laylatichy]

pecl and pear are not available in php8

However I have access to this command on php8 containers

@dominikzogg Having an non-compatible extension is 🆗 since PHP 8 event is still in beta. We have to wait

yes, but as you can see - /tmp/pear/temp/event/php7 - php7 pear, not 8, so that's why it's grabbing event for a php7 not v3

php8-pear is in community repo on alpine https://pkgs.alpinelinux.org/packages?name=php8-pear&branch=edge

btw workerman will work without event, I disabled it in my nano due to php8 pecl shenanigan's ;p will add it later on as well

[walkor]

@waghanza try command pecl install event-3.0.2 instead of pecl install event.

[waghanza]

@waghanza try command pecl install event-3.0.2 instead of pecl install event.

It's working, but I prefer avoid this. I think the only solution is to wait

[waghanza]

Thanks @laylatichy. I've made a little fix to containers definitions, so as pecl for php8 is used.

The changes is in php core, and seems not to be temp : php/php-src#3781

However, I'm a little bit confused about this : a C based extension should not be installed with https://github.com/FriendsOfPHP/pickle in php8 ?

[laylatichy]

Thanks @laylatichy. I've made a little fix to containers definitions, so as pecl for php8 is used.

The changes is in php core, and seems not to be temp : php/php-src#3781

However, I'm a little bit confused about this : a C based extension should not be installed with https://github.com/FriendsOfPHP/pickle in php8 ?

pickle last time I checked was still in a bit of beta state, we still have to wait for some frameworks here that use laminas deps for example so maybe it'll be ready by then

[waghanza]

seems that pickle is ready to be used @laylatichy

[waghanza]

We should have been noticed by renovatebot. Could you make a PR @limingxinleo ?

[limingxinleo]

@waghanza #4477

[waghanza]

@leocavalcante @sy-records I have finished this feature (I have to include hyperf beta and phalcon alpha to unblock this PR). May you quick review this ?

[waghanza]

https://the-benchmarker.semaphoreci.com/jobs/96c44ec8-afd0-4f94-95f6-96ef864c70d5#L4168 @limingxinleo

[waghanza]

@niden @leocavalcante @sy-records @laylatichy any idea about https://the-benchmarker.semaphoreci.com/jobs/e95a758b-481a-4311-973c-bef31558de32#L47191 ?

phalcon extension seems not load

[Jeckerson]

@waghanza This occur due missing header, will be fixed in next version.

https://github.com/phalcon/cphalcon/pull/15610/files#diff-90ad24223200fd3ab4bdd6b25c2264b1339b2f6693b8c4b3b869c0ff03cbb5a5R54

[waghanza]

@sy-records @leocavalcante @laylatichy @dominikzogg finally ... this PR is ready and CI is OK

the only think is that I use phalcon alpha @Jeckerson

thanks for your awesome contributions to all 🎉