Skip to content

Conversation

waghanza
Copy link
Collaborator

Hi,

This PR add hanami

@see #140

Regards,

@waghanza waghanza merged commit a6a80a2 into the-benchmarker:master Jun 22, 2018
@waghanza waghanza deleted the add_hanami branch June 22, 2018 21:36
@jodosha
Copy link
Contributor

jodosha commented Aug 6, 2018

@waghanza Thanks for adding Hanami. Please check if it's working correctly and in production mode (check Hanami.env?(:production)). I don't see routes definition, so it could be it's hitting 404 or raising internal exceptions. Thanks.

@waghanza
Copy link
Collaborator Author

waghanza commented Aug 6, 2018

Thanks for checking this @jodosha

Routes are defined here =>
https://github.com/the-benchmarker/web-frameworks/blob/master/ruby/hanami/apps/web/config/routes.rb

In fact, I've done multiples PR to add hanami.

It appears that I forget to configure it as production

@jodosha
Copy link
Contributor

jodosha commented Aug 7, 2018

@waghanza Thanks for getting back. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants