Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a fix for issue #89 and tests for @as_record. #90

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

maxd13
Copy link

@maxd13 maxd13 commented Jun 29, 2020

Tests are passing in both version 1.4.2 and 1.3.1

@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #90 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   90.20%   90.34%   +0.13%     
==========================================
  Files          28       28              
  Lines        1338     1336       -2     
==========================================
  Hits         1207     1207              
+ Misses        131      129       -2     
Impacted Files Coverage Δ
src/Record.jl 94.54% <ø> (+3.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fc1205...b6a525c. Read the comment docs.

Copy link
Owner

@thautwarm thautwarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'd appreciate a lot.
I'll merge this with a small change tomorrow(about the trailing space).

@thautwarm thautwarm merged commit 43f71f6 into thautwarm:master Jun 30, 2020
@thautwarm
Copy link
Owner

Thanks again for the impressive notes about expression problem.
I'd like to add it to documentations.

Besides, your git config seems broken, so that you were not recorded at https://github.com/thautwarm/MLStyle.jl/graphs/contributors.
I'd recommend you to set email via git config (--global) user.email xxx@xxx.

To add you to the contributors, I'm to fix the git tree because I don't want to
loss a conscientious contributor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants