Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sidecar: Handle intermediate restarts of sidecar gracefully. #941

Merged
merged 1 commit into from
Mar 19, 2019

Conversation

bwplotka
Copy link
Member

Fixes #934

CC @SuperQ

Signed-off-by: Bartek Plotka bwplotka@gmail.com

@bwplotka bwplotka changed the title Handle intermediate restarts of sidecar gracefully. sidecar: Handle intermediate restarts of sidecar gracefully. Mar 19, 2019
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
@bwplotka
Copy link
Member Author

Can you try this out @SuperQ ?

Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This anonymous function is getting quite long. I would recommend to refactor things to eliminate the anonymous function that seems to be there simply to get around variable scope.

@bwplotka bwplotka merged commit cd2061d into master Mar 19, 2019
@bwplotka bwplotka deleted the 934-shipper-upload-failure branch March 19, 2019 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants