WIP: Update the shipper metadata after each upload #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So essentially you would like to have updated meta.json lying around? hmm useful for manual upload of blocks as well. Worth to double check in some e2e/integration test at some point that Prometheus can still read that meta, but otherwise.. it might be fine. Why is that required though? |
|
See the linked issue. The shipper iterates over all of the compacted blocks in one go, we're uploading ~6 months of week-size blocks. So if one of the couple dozen blocks gets a storage error, all of the previously uploaded blocks don't get marked as complete. Then it retries and finds all of the previously uploaded OK blocks as overlapping. |
Partly fixes #934 Signed-off-by: Ben Kochie <superq@gmail.com>
|
Yea, this doesn't work as expected, it drops all blocks after the the last block upload. |
SuperQ
changed the title
|
This is the wrong fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update the shipper metadata after each upload rather than waiting to the end of the sync.
Partly fixes #934
Verification
Not tested yet.