Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow user to specify tls version for backward compatibility #7654

Merged
merged 11 commits into from
Oct 29, 2024

Conversation

pureiboi
Copy link
Contributor

@pureiboi pureiboi commented Aug 21, 2024

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

resolve issue #7624

  • expose flag to allow user to input tls version
  • when flag is not provided, default tls version to 1.3

Verification

sslscan is used to verify the tls version that was enabled

tls 1 3 tls 1 2

@pureiboi pureiboi force-pushed the feat/optional-tls-version branch 7 times, most recently from 26bb374 to f4b319a Compare August 21, 2024 16:47
Copy link
Contributor

@harry671003 harry671003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

cmd/thanos/config.go Outdated Show resolved Hide resolved
Signed-off-by: pureiboi <17396188+pureiboi@users.noreply.github.com>
Signed-off-by: pureiboi <17396188+pureiboi@users.noreply.github.com>
fpetkovski
fpetkovski previously approved these changes Sep 23, 2024
Signed-off-by: pureiboi <17396188+pureiboi@users.noreply.github.com>
@pureiboi pureiboi force-pushed the feat/optional-tls-version branch 2 times, most recently from 6b27e5f to 0b19464 Compare October 10, 2024 10:44
@pureiboi
Copy link
Contributor Author

pureiboi commented Oct 10, 2024

resolved conflict, and merged latest from main.

requires approval again

@pureiboi
Copy link
Contributor Author

@fpetkovski if you can help to review again

Signed-off-by: pureiboi <17396188+pureiboi@users.noreply.github.com>
Signed-off-by: pureiboi <17396188+pureiboi@users.noreply.github.com>
Signed-off-by: pureiboi <17396188+pureiboi@users.noreply.github.com
MichaHoffmann
MichaHoffmann previously approved these changes Oct 29, 2024
Signed-off-by: pureiboi <17396188+pureiboi@users.noreply.github.com>
@GiedriusS GiedriusS merged commit 6203811 into thanos-io:main Oct 29, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants