-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow user to specify tls version for backward compatibility #7654
Merged
GiedriusS
merged 11 commits into
thanos-io:main
from
pureiboi:feat/optional-tls-version
Oct 29, 2024
Merged
allow user to specify tls version for backward compatibility #7654
GiedriusS
merged 11 commits into
thanos-io:main
from
pureiboi:feat/optional-tls-version
Oct 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pureiboi
force-pushed
the
feat/optional-tls-version
branch
7 times, most recently
from
August 21, 2024 16:47
26bb374
to
f4b319a
Compare
harry671003
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you.
pureiboi
force-pushed
the
feat/optional-tls-version
branch
from
August 22, 2024 04:12
57e94a5
to
7270ec5
Compare
Signed-off-by: pureiboi <17396188+pureiboi@users.noreply.github.com>
Signed-off-by: pureiboi <17396188+pureiboi@users.noreply.github.com>
pureiboi
force-pushed
the
feat/optional-tls-version
branch
from
September 21, 2024 17:24
7270ec5
to
6878d60
Compare
fpetkovski
previously approved these changes
Sep 23, 2024
pureiboi
force-pushed
the
feat/optional-tls-version
branch
from
October 10, 2024 05:50
c5cda5a
to
5e81f46
Compare
Signed-off-by: pureiboi <17396188+pureiboi@users.noreply.github.com>
pureiboi
force-pushed
the
feat/optional-tls-version
branch
2 times, most recently
from
October 10, 2024 10:44
6b27e5f
to
0b19464
Compare
resolved conflict, and merged latest from main. requires approval again |
@fpetkovski if you can help to review again |
Signed-off-by: pureiboi <17396188+pureiboi@users.noreply.github.com>
pureiboi
force-pushed
the
feat/optional-tls-version
branch
from
October 17, 2024 13:20
1371656
to
fad7f4b
Compare
Signed-off-by: pureiboi <17396188+pureiboi@users.noreply.github.com>
pureiboi
force-pushed
the
feat/optional-tls-version
branch
from
October 17, 2024 13:34
fad7f4b
to
b1fac60
Compare
Signed-off-by: pureiboi <17396188+pureiboi@users.noreply.github.com
pureiboi
force-pushed
the
feat/optional-tls-version
branch
from
October 29, 2024 00:33
9de954a
to
b370f3d
Compare
MichaHoffmann
previously approved these changes
Oct 29, 2024
Signed-off-by: pureiboi <17396188+pureiboi@users.noreply.github.com>
pureiboi
force-pushed
the
feat/optional-tls-version
branch
from
October 29, 2024 10:20
b0623c3
to
a81911f
Compare
GiedriusS
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
resolve issue #7624
Verification
sslscan is used to verify the tls version that was enabled