API: Add limit param in metadata APIs #7609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>
harry671003
force-pushed
the
implement_limit_in_api
branch
from
384aff2
to
a211347
Compare
harry671003
changed the title
harry671003
changed the title
saswatamcode
previously approved these changes
Aug 8, 2024
Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com>
yeya24
approved these changes
Aug 8, 2024
| @@ -16,6 +16,7 @@ We use *breaking :warning:* to mark changes that are not backward compatible (re | |||
| * [#7592](https://github.com/thanos-io/thanos/pull/7592) Ruler: Only increment `thanos_rule_evaluation_with_warnings_total` metric for non PromQL warnings. | |||
|
|
|||
| ### Added | |||
| * [7609](https://github.com/thanos-io/thanos/pull/7609) API: Add limit param to metadata APIs (series, label names, label values). | |||
There was a problem hiding this comment.
I think we can omit the changelog here and add in the actual store implementation PR.
But not a big deal. We can update the changelog when you create another PR
There was a problem hiding this comment.
This missed #. We can fix in your next pr
jnyi
pushed a commit
to jnyi/thanos
that referenced
this pull request
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Prometheus recently introduced
limitparam in metadata APIs to allow users to opt for a limited number of results.This PR implements the limit param in Thanos API.
Verification
Related