-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add Store metrics #7540
base: main
Are you sure you want to change the base?
Docs: Add Store metrics #7540
Conversation
Signed-off-by: Tomiwa <tomiwaaribisala@gmail.com>
How are you generating this? Are you doing this manually? |
Yes, i am generating the metrics manually by deepdiving into the source code and using the Thanos Query endpoint( |
Signed-off-by: Tomiwa <tomiwaaribisala@gmail.com>
Hmm while this is good work, I think doing this manually is probably not the way to go about it. This won't be auto-populated in docs. What happens in case we change these metrics, and forget to update doc? |
Well there were discussions about this scenario in the |
@saswatamcode this should be handled in the same way as if we update code and forget to update the respective documentation. |
Signed-off-by: Tomiwa <tomiwaaribisala@gmail.com>
Signed-off-by: Tomiwa <tomiwaaribisala@gmail.com>
Updated Store Gateway metrics, @douglascamata. |
Docs: Add Store metrics, @douglascamata.