Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add Store metrics #7540

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

TomiwaAribisala-git
Copy link

Docs: Add Store metrics, @douglascamata.

Signed-off-by: Tomiwa <tomiwaaribisala@gmail.com>
@saswatamcode
Copy link
Member

How are you generating this? Are you doing this manually?

@TomiwaAribisala-git
Copy link
Author

TomiwaAribisala-git commented Jul 15, 2024

How are you generating this? Are you doing this manually?

Yes, i am generating the metrics manually by deepdiving into the source code and using the Thanos Query endpoint(api/v1/metadata) referenced in this issue.

Signed-off-by: Tomiwa <tomiwaaribisala@gmail.com>
@saswatamcode
Copy link
Member

Hmm while this is good work, I think doing this manually is probably not the way to go about it. This won't be auto-populated in docs. What happens in case we change these metrics, and forget to update doc?

@TomiwaAribisala-git
Copy link
Author

Hmm while this is good work, I think doing this manually is probably not the way to go about it. This won't be auto-populated in docs. What happens in case we change these metrics, and forget to update doc?

Well there were discussions about this scenario in the thanos-dev Slack channel which has not been concluded; please see this @douglascamata, and approving changes for this PR.

@douglascamata
Copy link
Contributor

@saswatamcode this should be handled in the same way as if we update code and forget to update the respective documentation.

Signed-off-by: Tomiwa <tomiwaaribisala@gmail.com>
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jul 23, 2024
Signed-off-by: Tomiwa <tomiwaaribisala@gmail.com>
@TomiwaAribisala-git
Copy link
Author

Updated Store Gateway metrics, @douglascamata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants