Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG: Mark 0.35 as in progress #7312

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

saswatamcode
Copy link
Member

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Copy link
Contributor

@MichaHoffmann MichaHoffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fpetkovski
Copy link
Contributor

Do we want to get #7310 and some other PRs in?

@saswatamcode
Copy link
Member Author

saswatamcode commented Apr 29, 2024

The release has been pending for a bit now, but we can wait for a couple more PRs. Did you have any other in mind @fpetkovski?

@fpetkovski
Copy link
Contributor

I would like to add label names and values sharding as a follow up to #7200. I can raise a PR today for that.

@fpetkovski
Copy link
Contributor

Looks like @MichaHoffmann already did this in https://github.com/thanos-io/thanos/pull/7309/files. So maybe we can just merge the draft PR about removing replica labels and then we'll be good to go.

@saswatamcode
Copy link
Member Author

Ok those have been merged, so marking as in-progress

@saswatamcode saswatamcode merged commit d9508cc into thanos-io:main Apr 29, 2024
20 checks passed
Nashluffy pushed a commit to Nashluffy/thanos that referenced this pull request May 14, 2024
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Signed-off-by: mluffman <nashluffman@gmail.com>
jnyi pushed a commit to jnyi/thanos that referenced this pull request Jun 1, 2024
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
jnyi pushed a commit to jnyi/thanos that referenced this pull request Jun 4, 2024
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants