Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhide distributed execution mode #7175

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

fpetkovski
Copy link
Contributor

@fpetkovski fpetkovski commented Mar 3, 2024

Unhide distributed execution mode

This commit exposes the distributed query execution mode to end-users by unhiding the flag used to toggle this feature.

The commit also adds documentation on when the mode is appropriate to be used.

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Expose the query.mode flag which allows toggling the distributed query execution mode.
  • Made modifications to the UI to disable options which are not yet supported in this mode (toggling deduplication, partial response and downsampling).

Verification

  • We've been running with this mode for along time in production.
  • Tested the UI manually.

@fpetkovski fpetkovski force-pushed the distributed-query-mode branch 3 times, most recently from 8be9ea6 to 68753f4 Compare March 4, 2024 12:37
@fpetkovski fpetkovski marked this pull request as ready for review March 4, 2024 12:40
This commit exposes the distributed query execution mode to end-users by unhiding the
flag used to toggle this feature.

The commit also adds documentation on when the mode is appropriate to be used.

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@MichaHoffmann
Copy link
Contributor

I think this just needs to make docs again; otherwise looks good to me!

@fpetkovski
Copy link
Contributor Author

Let me fix docs on main since I will have to update some links anyway after the merge.

@fpetkovski fpetkovski merged commit 4166776 into thanos-io:main Mar 5, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants