Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

receive/multitsdb: do not delete not uploaded blocks #7166

Merged
merged 3 commits into from
Apr 16, 2024
Merged

receive/multitsdb: do not delete not uploaded blocks #7166

merged 3 commits into from
Apr 16, 2024

Commits on Apr 2, 2024

  1. receive/multitsdb: do not delete not uploaded blocks 

    If a block hasn't been uploaded yet then tell the TSDB layer not to
delete them. This prevents a nasty race where the TSDB layer can delete
a block before the shipper gets to it. I saw this happen with a very
small block.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
    @GiedriusS
    GiedriusS committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    f175b1b View commit details
    Browse the repository at this point in the history

  2. receive/multitsdb: change order 

    Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
    @GiedriusS
    GiedriusS committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    36f5ff1 View commit details
    Browse the repository at this point in the history

  3. shipper/receive: just use a single lock 

    Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
    @GiedriusS
    GiedriusS committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    48f502c View commit details
    Browse the repository at this point in the history