Store: dont rely on slice labels continued #7099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaHoffmann
force-pushed
the
mhoffm-dont-use-slice-labels-continued
branch
from
c938b6b
to
20de183
Compare
squat
reviewed
Jan 27, 2024
| @@ -118,20 +118,19 @@ require ( | |||
| require ( | |||
| github.com/mitchellh/go-ps v1.0.0 | |||
| github.com/onsi/gomega v1.27.10 | |||
| github.com/prometheus-community/prom-label-proxy v0.7.0 | |||
| github.com/prometheus-community/prom-label-proxy v0.8.1-0.20240127162815-c1195f9aabc0 | |||
There was a problem hiding this comment.
Thanks for merging! 🙇
Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
MichaHoffmann
force-pushed
the
mhoffm-dont-use-slice-labels-continued
branch
from
20de183
to
2f861d8
Compare
fpetkovski
approved these changes
Jan 29, 2024
| } | ||
| } | ||
| b := labels.NewBuilder(lset) | ||
| extend.Range(func(l labels.Label) { |
There was a problem hiding this comment.
I think this introduces a double for loop, but it might not be as bad in real world cases.
There was a problem hiding this comment.
It benchmarks 3x worse for what we have, a solution is to pass in extend still as a slice but that would need way more refactoring.
There was a problem hiding this comment.
I think this is fine for now, we can optimize if it shows in a profile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Converted some other slice label usages to be stringlabel compatible. I fear that performance will take a hit because we are not very economical with our labels.Builders here, but i'm happy if tests pass first of all.
Verification
Previous Tests still pass hopefully