DONT MERGE: receive: per tenant sharding #6302

mhoffm-aiven · 2023-04-20T12:23:21Z

This is an experiment for per-tenant sharding. This is beneficial for situations where no natural fit for a tenant exists or the ingest path does not allow for effective multitenancy because we can still do relabel sharding on the newly introduced shard_id label and scale compactor and store horizontally this way.

It is achieved by just opening N TSDBs per tenant and choosing the one to insert by hashing the labelset somehow ( one could generalize and reuse hashring here ).

I stubbed out several methods and tests to get something to experiment with quick, but the issues probably can be solved straigth forward.

Is this something interesting?

sonatype-lift · 2023-04-20T12:28:42Z

pkg/receive/multitsdb.go

@@ -171,26 +181,26 @@
 	return newLocalClient(client, tsdbStore.LabelSet, tsdbStore.TimeRange)
 }

-func (t *tenant) exemplars() *exemplars.TSDB {
+func (t *tenantShard) exemplars() *exemplars.TSDB {


U1000: func (*tenantShard).exemplars is unused

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-04-20T12:28:44Z

pkg/receive/multitsdb.go

 }

 // pruneTSDB removes a TSDB if its past the retention period.
 // It compacts the TSDB head, sends all remaining blocks to S3 and removes the TSDB from disk.
-func (t *MultiTSDB) pruneTSDB(ctx context.Context, logger log.Logger, tenantInstance *tenant) (bool, error) {
-	tenantTSDB := tenantInstance.readyStorage()
+func (t *MultiTSDB) pruneTSDB(ctx context.Context, logger log.Logger, tenantShard *tenantShard) (bool, error) {


U1000: func (*MultiTSDB).pruneTSDB is unused

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-04-20T12:28:46Z

pkg/receive/multitsdb.go

@@ -37,6 +37,9 @@
 	"github.com/thanos-io/thanos/pkg/store/storepb"
 )

+// TODO: make configurable


godot: Comment should end in a period

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-04-20T12:28:48Z

pkg/receive/multitsdb.go

@@ -171,26 +181,26 @@
 	return newLocalClient(client, tsdbStore.LabelSet, tsdbStore.TimeRange)
 }

-func (t *tenant) exemplars() *exemplars.TSDB {
+func (t *tenantShard) exemplars() *exemplars.TSDB {


unused: func (*tenantShard).exemplars is unused

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-04-20T12:28:50Z

pkg/receive/multitsdb.go

 }

 // pruneTSDB removes a TSDB if its past the retention period.
 // It compacts the TSDB head, sends all remaining blocks to S3 and removes the TSDB from disk.
-func (t *MultiTSDB) pruneTSDB(ctx context.Context, logger log.Logger, tenantInstance *tenant) (bool, error) {
-	tenantTSDB := tenantInstance.readyStorage()
+func (t *MultiTSDB) pruneTSDB(ctx context.Context, logger log.Logger, tenantShard *tenantShard) (bool, error) {


unused: func (*MultiTSDB).pruneTSDB is unused

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

pkg/receive/multitsdb_test.go

sonatype-lift · 2023-04-30T12:45:24Z

pkg/receive/multitsdb_test.go

@@ -477,8 +475,9 @@
 		})
 	}
 }
+*/

 func syncTSDBs(ctx context.Context, m *MultiTSDB, interval time.Duration) error {


U1000: func syncTSDBs is unused

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-04-30T12:45:26Z

pkg/receive/multitsdb_test.go

 	l := labels.FromStrings("a", "1", "b", "2")

 	b.ReportAllocs()
 	b.ResetTimer()

+	w := NewWriter(m.logger, m, &WriterOptions{})
+
 	for i := 0; i < b.N; i++ {


errcheck: Error return value of w.Write is not checked

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-04-30T12:45:28Z

pkg/receive/multitsdb_test.go

@@ -477,8 +475,9 @@
 		})
 	}
 }
+*/

 func syncTSDBs(ctx context.Context, m *MultiTSDB, interval time.Duration) error {


unused: func syncTSDBs is unused

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

stale · 2023-06-18T07:10:29Z

Hello 👋 Looks like there was no activity on this amazing PR for the last 30 days.
Do you mind updating us on the status? Is there anything we can help with? If you plan to still work on it, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next week, this issue will be closed (we can always reopen a PR if you get back to this!). Alternatively, use remind command if you wish to be reminded at some point in future.

pull-request-size bot added the size/XL label Apr 20, 2023

sonatype-lift bot reviewed Apr 20, 2023

View reviewed changes

receive: per tenant sharding

539cb12

mhoffm-aiven force-pushed the mhoffm-per-tenant-sharding branch from d9cb869 to 539cb12 Compare April 20, 2023 12:45

sonatype-lift bot reviewed Apr 27, 2023

View reviewed changes

pkg/receive/multitsdb_test.go Show resolved Hide resolved

sonatype-lift bot reviewed Apr 27, 2023

View reviewed changes

pkg/receive/multitsdb_test.go Show resolved Hide resolved

mhoffm-aiven force-pushed the mhoffm-per-tenant-sharding branch 2 times, most recently from 699fccc to 59bc761 Compare April 30, 2023 12:40

sonatype-lift bot reviewed Apr 30, 2023

View reviewed changes

wip: per tenant sharding

4ebab57

mhoffm-aiven force-pushed the mhoffm-per-tenant-sharding branch from 59bc761 to 4ebab57 Compare May 15, 2023 08:33

stale bot added the stale label Jun 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DONT MERGE: receive: per tenant sharding #6302

DONT MERGE: receive: per tenant sharding #6302

mhoffm-aiven commented Apr 20, 2023

sonatype-lift bot Apr 20, 2023

sonatype-lift bot Apr 20, 2023

sonatype-lift bot Apr 20, 2023

sonatype-lift bot Apr 20, 2023

sonatype-lift bot Apr 20, 2023

sonatype-lift bot Apr 30, 2023

sonatype-lift bot Apr 30, 2023

sonatype-lift bot Apr 30, 2023

stale bot commented Jun 18, 2023

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

DONT MERGE: receive: per tenant sharding #6302

Are you sure you want to change the base?

DONT MERGE: receive: per tenant sharding #6302

Conversation

mhoffm-aiven commented Apr 20, 2023

sonatype-lift bot Apr 20, 2023

Choose a reason for hiding this comment

sonatype-lift bot Apr 20, 2023

Choose a reason for hiding this comment

sonatype-lift bot Apr 20, 2023

Choose a reason for hiding this comment

sonatype-lift bot Apr 20, 2023

Choose a reason for hiding this comment

sonatype-lift bot Apr 20, 2023

Choose a reason for hiding this comment

sonatype-lift bot Apr 30, 2023

Choose a reason for hiding this comment

sonatype-lift bot Apr 30, 2023

Choose a reason for hiding this comment

sonatype-lift bot Apr 30, 2023

Choose a reason for hiding this comment

stale bot commented Jun 18, 2023