Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools bucket replicate: concurrent replication #6174

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Kartik-Garg
Copy link
Contributor

@Kartik-Garg Kartik-Garg commented Mar 1, 2023

PR closes #4278

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Added a new flag in tools bucket replicate, which let's us choose the concurrency, blocks are first converted into groups based on external labels and downsampling, and then they are replicated concurrently.

Verification

Passed local and E2E tests

@Kartik-Garg Kartik-Garg force-pushed the tools-bucket-concurrent-replication branch 2 times, most recently from 86ec945 to 1f217ba Compare March 1, 2023 15:46
@pull-request-size pull-request-size bot added size/L and removed size/XL labels Mar 1, 2023
@Kartik-Garg Kartik-Garg force-pushed the tools-bucket-concurrent-replication branch from 1f217ba to b76c58b Compare March 1, 2023 17:31
@Kartik-Garg Kartik-Garg force-pushed the tools-bucket-concurrent-replication branch 6 times, most recently from c1d7af5 to 168b4fa Compare March 15, 2023 12:48
CHANGELOG.md Outdated Show resolved Hide resolved
cmd/thanos/tools_bucket.go Outdated Show resolved Hide resolved
pkg/replicate/scheme.go Show resolved Hide resolved
pkg/replicate/scheme.go Show resolved Hide resolved
pkg/replicate/replicator.go Outdated Show resolved Hide resolved
@Kartik-Garg Kartik-Garg force-pushed the tools-bucket-concurrent-replication branch 3 times, most recently from a9737b1 to 8eefd01 Compare April 20, 2023 09:21
Converted blocks into groups and then replicated those blocks in groups using go-routines.

Signed-off-by: Kartik-Garg <kartik.garg@infracloud.io>
@Kartik-Garg Kartik-Garg force-pushed the tools-bucket-concurrent-replication branch from 8eefd01 to 0262415 Compare April 24, 2023 09:20
@stale
Copy link

stale bot commented Jun 18, 2023

Hello 👋 Looks like there was no activity on this amazing PR for the last 30 days.
Do you mind updating us on the status? Is there anything we can help with? If you plan to still work on it, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next week, this issue will be closed (we can always reopen a PR if you get back to this!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tools bucket replicate: concurrent replication
2 participants