Store: Add a few objectives for Store's data touched/fetched amount and sizes #5819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglascamata
changed the title
The intent is to provide some metrics that will help inform users when setting values for the flags `store.grpc.series-sample-limit` and `store.grpc.touched-series-limit`. Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
douglascamata
force-pushed
the
bucket-store-data-touched-fetched-objectives
branch
from
589a285
to
cbf3484
Compare
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
douglascamata
force-pushed
the
bucket-store-data-touched-fetched-objectives
branch
from
cbf3484
to
a4cea43
Compare
moadz
suggested changes
Oct 26, 2022
|
@moadz I would love to simplify and make the metric names shorter, but I don't think it's a good idea to change their names after they have been out since many releases. The reason is that people might be already relying on them for dashboards (i.e. kube-thanos uses them) and alerts. |
Co-authored-by: Moad Zardab <zardab12@hotmail.com> Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
moadz
previously approved these changes
Oct 26, 2022
There was a problem hiding this comment.
@douglascamata you're absolutely right. I misread the diff and thought you were adding them as new metrics :) Bucket changes LGTM
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
…data-touched-fetched-objectives
…data-touched-fetched-objectives
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
2 tasks
…data-touched-fetched-objectives
matej-g
reviewed
Nov 23, 2022
| @@ -34,6 +34,7 @@ We use *breaking :warning:* to mark changes that are not backward compatible (re | |||
| ### Removed | |||
|
|
|||
| - [#5824](https://github.com/thanos-io/thanos/pull/5824) Mixin: Remove noisy `ThanosReceiveTrafficBelowThreshold` alert. | |||
| - [#5819](https://github.com/thanos-io/thanos/pull/5819) Store: Add a few objectives for Store's data touched/fetched amount and sizes. They are: 50, 95, and 99 quantiles. | |||
There was a problem hiding this comment.
I guess this was accidentally put into removed section instead of added?
2 tasks
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
May 18, 2023
…nd sizes (thanos-io#5819) * Add a few objectives for Store's data touched/fetched The intent is to provide some metrics that will help inform users when setting values for the flags `store.grpc.series-sample-limit` and `store.grpc.touched-series-limit`. Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Update CHANGELOG Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Update some metric's help text Co-authored-by: Moad Zardab <zardab12@hotmail.com> Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Remove quantiles from redundant metric Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Fix spelling Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Fix some metric help texts Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> Co-authored-by: Moad Zardab <zardab12@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Douglas Camata 159076+douglascamata@users.noreply.github.com
Changes
The intent is to provide some metrics that will help inform users when setting values for the flags
store.grpc.series-sample-limitandstore.grpc.touched-series-limit.Verification