Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.*: fix: re-enable some golang runtime metrics #5696

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

vhbfernandes
Copy link
Contributor

We are experiencing some high gc times and during debugging sessions, we figured out that the go_gc_pause.* metrics were accidentally disabled on an earlier upgrade of the Prometheus client, this PR re-enables it.

Signed-off-by: Victor Fernandes victorhbfernandes@gmail.com

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

Manually ran the docker container and ensure the go_gc_pauses_seconds_total_bucket was present

Signed-off-by: Victor Fernandes <victorhbfernandes@gmail.com>
Copy link
Contributor

@fpetkovski fpetkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@squat
Copy link
Member

squat commented Sep 16, 2022

Thanks!

@squat squat merged commit 4be755d into thanos-io:main Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants