Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: improve graph color #5144

Merged
merged 4 commits into from
Feb 11, 2022
Merged

Conversation

Nexucis
Copy link
Contributor

@Nexucis Nexucis commented Feb 11, 2022

I'm reporting the improvement made by @suyashtava in Prometheus through: prometheus/prometheus#10179

Note: After this PR we should be able to remove the old UI like we did in Prometheus \o/.

Signed-off-by: Augustin Husson husson.augustin@gmail.com

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thx! Thanks for helping us keep the UI in Thanos up to date 🍻

@GiedriusS GiedriusS merged commit e7d00fe into thanos-io:main Feb 11, 2022
@Nexucis Nexucis deleted the feature/graph-color branch February 11, 2022 10:31
Nicholaswang pushed a commit to Nicholaswang/thanos that referenced this pull request Mar 6, 2022
* improve graph color

Signed-off-by: Augustin Husson <husson.augustin@gmail.com>

* apply linter

Signed-off-by: Augustin Husson <husson.augustin@gmail.com>

* add assets

Signed-off-by: Augustin Husson <husson.augustin@gmail.com>

* add changelog

Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Signed-off-by: Nicholaswang <wzhever@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants