Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

objectstore/cos: add endpoint field for config vpc internal endpoint #4999

Merged
merged 4 commits into from
Dec 29, 2021

Conversation

hanjm
Copy link
Member

@hanjm hanjm commented Dec 26, 2021

Signed-off-by: Jimmie Han hanjinming@outlook.com

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  1. Add endpoint field to COS object store config.
  2. Add document and validate test.

Verification

  1. Unit test.
  2. Real depoyment test.

@hanjm hanjm force-pushed the feature/jimmiehan-support-cos-endpoint branch from b5a99ce to 6fa7402 Compare December 26, 2021 08:23
@hanjm
Copy link
Member Author

hanjm commented Dec 26, 2021

CI is broken, it will fixed by #5000.

@hanjm hanjm force-pushed the feature/jimmiehan-support-cos-endpoint branch from 6fa7402 to 7cbed9e Compare December 28, 2021 05:18
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks super good!

docs/storage.md Outdated Show resolved Hide resolved
Signed-off-by: Jimmie Han <hanjinming@outlook.com>
Signed-off-by: Jimmie Han <hanjinming@outlook.com>
Signed-off-by: Jimmie Han <hanjinming@outlook.com>
@hanjm hanjm force-pushed the feature/jimmiehan-support-cos-endpoint branch from 7cbed9e to 98e5a02 Compare December 29, 2021 12:20
Signed-off-by: Jimmie Han <hanjinming@outlook.com>
@hanjm hanjm force-pushed the feature/jimmiehan-support-cos-endpoint branch from 98e5a02 to a88e793 Compare December 29, 2021 12:20
@hanjm hanjm requested a review from yeya24 December 29, 2021 12:56
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yeya24 yeya24 merged commit bf14049 into thanos-io:main Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants