Add custom CA support for azure #4974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: clyang82 <chuyang@redhat.com>
Signed-off-by: clyang82 <chuyang@redhat.com>
clyang82
force-pushed
the
custom_ca_azure
branch
from
3db4956
to
f8b5a12
Compare
wiardvanrij
previously approved these changes
Dec 20, 2021
|
Yes. Agree with your point. I have checked again. besides S3 and Azure, cos also need support tls_config. I will have a |
Signed-off-by: clyang82 <chuyang@redhat.com>
GiedriusS
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: clyang82 chuyang@redhat.com
Changes
use tls_config to connect with azure object store so that we can pass the certificate in.
part of #4820
Verification