Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude blocks marked for deletion #4970

Merged
merged 7 commits into from
Dec 20, 2021
Merged

Exclude blocks marked for deletion #4970

merged 7 commits into from
Dec 20, 2021

Conversation

metonymic-smokey
Copy link
Contributor

@metonymic-smokey metonymic-smokey commented Dec 17, 2021 •
edited by yeya24
Loading

Fixes #4929

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Adding a flag to tools bucket ls to exclude blocks marked from deletion in the ls output.

Verification

Marked a block using tools bucket mark and verified that it did not appear in subsequent ls output.

@metonymic-smokey
Copy link
Contributor Author

Todo:

  1. Is an extra deleteDelay flag required to filter or should I set it to some default duration?
  2. Update docs and CHANGELOG.

@metonymic-smokey
small refactor
b069b47 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
yeya24
yeya24 reviewed Dec 17, 2021
View reviewed changes
cmd/thanos/tools_bucket.go Outdated Show resolved Hide resolved
@metonymic-smokey
used a more efficient approach
01948e5 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
updated docs
0ee7e7f 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
yeya24
yeya24 requested changes Dec 18, 2021
View reviewed changes
cmd/thanos/tools_bucket.go Outdated Show resolved Hide resolved
@metonymic-smokey
eliminated if else block
b97ecb7 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey metonymic-smokey marked this pull request as ready for review December 19, 2021 03:20
@yeya24
Copy link
Contributor

yeya24 commented Dec 20, 2021

@metonymic-smokey LGTM. Can you add a changelog entry?

@metonymic-smokey
updated CHANGELOG
ade49a3 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@yeya24 yeya24 changed the title Draft - Exclude blocks marked for deletion Exclude blocks marked for deletion Dec 20, 2021
@yeya24 yeya24 enabled auto-merge (squash) December 20, 2021 08:46
yeya24
yeya24 approved these changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yeya24 yeya24 merged commit c3325d6 into thanos-io:main Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeya24 yeya24 yeya24 approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add flag to "thanos tools bucket ls" to exclude marked blocks
2 participants
@metonymic-smokey @yeya24