Tracing: add traceid_128bit support for jaeger
#4942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanjm
force-pushed
the
feature/jimmiehan-add-jaeger-config-gen128bit
branch
2 times, most recently
from
e5fb2ae
to
217bcee
Compare
hanjm
changed the title
traceid_128bit support for jaeger.
hanjm
changed the title
traceid_128bit support for jaeger.traceid_128bit support for jaeger
yeya24
reviewed
Dec 12, 2021
Signed-off-by: Jimmie Han <hanjinming@outlook.com>
Signed-off-by: Jimmie Han <hanjinming@outlook.com>
hanjm
force-pushed
the
feature/jimmiehan-add-jaeger-config-gen128bit
branch
from
217bcee
to
314a1b7
Compare
|
Thank @yeya24 , ci is OK. |
yeya24
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenTelemetry jaegerreceiver always write 128bit traceID to backend https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.41.0/pkg/translator/jaeger/jaegerthrift_to_traces.go#L95 , with leading zero.
like '00000000000000007aeab04b2badb0bd', but jaeger query will parse it to 64bit traceid to search https://github.com/jaegertracing/jaeger/blob/main/model/ids.go#L51.
One of solution is make jaeger client use 1238bit traceID.
Changes
traceid_128bitfield to tracing config, align to same field in jaeger config .Verification