Fixing force tracing with Jaeger #4918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denys Zhdanov <denys.zhdanov@adevinta.com>
deniszh
force-pushed
the
DZ-Jaeger-Force
branch
from
dca5978
to
3510f2f
Compare
squat
reviewed
Dec 1, 2021
squat
reviewed
Dec 1, 2021
deniszh
force-pushed
the
DZ-Jaeger-Force
branch
from
bf38935
to
0b856f7
Compare
Signed-off-by: Denys Zhdanov <denys.zhdanov@adevinta.com> fixing formatting Signed-off-by: Denys Zhdanov <denys.zhdanov@adevinta.com> fixing formatting
deniszh
force-pushed
the
DZ-Jaeger-Force
branch
from
0b856f7
to
9477ef1
Compare
|
CircleCI seems dead, merging with admin rights |
aarontams
pushed a commit
to aarontams/thanos
that referenced
this pull request
Dec 5, 2021
* lowering ForceTracingBaggageKey to work with Jaeger Signed-off-by: Denys Zhdanov <denys.zhdanov@adevinta.com> * Adding CHANGELOG entry Signed-off-by: Denys Zhdanov <denys.zhdanov@adevinta.com> fixing formatting Signed-off-by: Denys Zhdanov <denys.zhdanov@adevinta.com> fixing formatting Co-authored-by: Denys Zhdanov <denys.zhdanov@adevinta.com> Signed-off-by: aaron.tam <aaron.tam@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is replacement for stale PR #4018 by @conorevans
Changes
Make baggage key lowercase for Jaeger support. Per Jaeger documentation:
Verification
Not sure if it's easy to test. As original author, I'm not sure if spinning Jaeger and Thanos worth to test that.