Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compactor: Add metrics for retention progress #4848

Merged
merged 8 commits into from
Nov 12, 2021

Conversation

metonymic-smokey
Copy link
Contributor

@metonymic-smokey metonymic-smokey commented Nov 10, 2021

Fixes #4835

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Added a retention progress calculator, similar to the ones for compaction and downsampling.

Verification

@metonymic-smokey metonymic-smokey marked this pull request as draft November 10, 2021 14:29
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@yeya24
Copy link
Contributor

yeya24 commented Nov 10, 2021

Change is relevant to users. Can you update the changelog?

yeya24
yeya24 previously approved these changes Nov 10, 2021
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only some small nits about naming. Let's mark this pr for review.

pkg/compact/compact.go Outdated Show resolved Hide resolved
pkg/compact/compact.go Outdated Show resolved Hide resolved
@metonymic-smokey metonymic-smokey marked this pull request as ready for review November 11, 2021 02:47
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
pkg/compact/compact_test.go Outdated Show resolved Hide resolved
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@yeya24 yeya24 enabled auto-merge (squash) November 12, 2021 05:09
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yeya24 yeya24 merged commit aa7e9f3 into thanos-io:main Nov 12, 2021
@yeya24 yeya24 mentioned this pull request Nov 13, 2021
2 tasks
@yeya24 yeya24 mentioned this pull request Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compact: Retention progress metrics
2 participants