Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics for compaction and downsampling process #4801

Merged
merged 75 commits into from
Nov 6, 2021
Merged

Metrics for compaction and downsampling process #4801

merged 75 commits into from
Nov 6, 2021

Conversation

metonymic-smokey
Copy link
Contributor

@metonymic-smokey metonymic-smokey commented Oct 26, 2021 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

This PR adds metrics to tracks the progress of compaction and downsampling such as number of iterations, blocks, etc.
Fixes #3985

Verification

Metrics shown on the /metrics endpoint:
Compaction:
image

Downsampling:
image

metonymic-smokey and others added 30 commits October 16, 2021 10:15
@metonymic-smokey
fixed template; export metadata
6fb9752 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
added some error handling
f403fcc 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
remove planned blocks from original
02d7037 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
moved to pkg/compact
ea83250 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
draft: export metrics to Prom
ff2e36a 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
update metrics after entire plan sim; change func name
5961552 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
added method to delete metas from group
a2b2b97 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
preallocate meta slice
8f13acc 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
changed func signature; started adding metrics to Group
f52e056 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
added termination condition
ad639c1 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
metrics struct added
845d497 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
draft: updating progress metric
cc4efe4 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
added feature flag for compact
322340b 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
use tsdb planner as default
a4642f6 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
initialised maps with size; changed metrics update map
3092479 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
removed extra vars; changed prom init location
7f91580 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
added labels and downsample resolution to metadata
5fd74c6 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
added termination condition; reverted planner type
6f0b74a 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
Merge branch 'thanos-io:main' into metrics
ec3e767
@metonymic-smokey
draft: downsampling metrics overview
a3dfae1 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
Merge branch 'metrics' of https://github.com/metonymic-smokey/thanos …
772041a 
…into metrics
@metonymic-smokey
removed extra bkt; processing individual blocks
ad4c704 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
Merge branch 'thanos-io:main' into metrics
3c7b8ac
@metonymic-smokey
changed downsample sim logic; changed plan metric names
e6739d7 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
re-used interface; refactoring
b4a662b 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
draft: added Prom metrics
cdeb0d7 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
re-used planner; added flag; fixed interface
7a53935 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
increment exporters; renamed funcs/structs
3b90846 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
check if downsampling is disabled
da04db8 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
iterate through groups instead of meta
8922b33 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
draft: refactor compact progress test
639b964 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
draft: refactor downsample test
c0caf42 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
yeya24
yeya24 reviewed Nov 5, 2021
View reviewed changes
pkg/compact/compact_test.go Outdated Show resolved Hide resolved
pkg/compact/compact_test.go Outdated Show resolved Hide resolved
pkg/compact/compact_test.go Outdated Show resolved Hide resolved
@metonymic-smokey
lint fixes and code clean up
a58b63f 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
yeya24
yeya24 reviewed Nov 5, 2021
View reviewed changes
pkg/compact/compact_test.go Outdated Show resolved Hide resolved
pkg/compact/compact_test.go Outdated Show resolved Hide resolved
pkg/compact/compact_test.go Outdated Show resolved Hide resolved
pkg/compact/compact_test.go Outdated Show resolved Hide resolved
@metonymic-smokey metonymic-smokey force-pushed the compact-metrics branch 2 times, most recently from 8146daf to 1bd7b17 Compare November 5, 2021 08:57
@metonymic-smokey
draft: refactored compact progress test
8ec72e6 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
changed func signature
e10c845 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
draft: refactored downsample unit test to use helper func
3d0d375 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
yeya24
yeya24 reviewed Nov 5, 2021
View reviewed changes
pkg/compact/compact_test.go Outdated Show resolved Hide resolved
@metonymic-smokey
improved test cases; CircleCI fix
6999f7f 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
yeya24
yeya24 reviewed Nov 6, 2021
View reviewed changes
pkg/compact/compact.go Outdated Show resolved Hide resolved
cmd/thanos/compact.go Outdated
originalMetas := sy.Metas()
groups, err := grouper.Groups(originalMetas)
if err != nil {
return errors.Wrapf(err, "could not group original metadata")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still not solved @metonymic-smokey

yeya24
yeya24 reviewed Nov 6, 2021
View reviewed changes
cmd/thanos/compact.go Outdated Show resolved Hide resolved
cmd/thanos/compact.go Outdated Show resolved Hide resolved
@metonymic-smokey
use reset instead of unregister; minor nits
37848f1 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
improved downsample test case
e366232 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
E2E test fix
50d1be4 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@metonymic-smokey
added CHANGELOG
02bb607 
Signed-off-by: metonymic-smokey <ahuja.aditi@gmail.com>
@yeya24 yeya24 enabled auto-merge (squash) November 6, 2021 14:47
yeya24
yeya24 approved these changes Nov 6, 2021
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the patience. Let's try it!

@yeya24 yeya24 merged commit eca25c4 into thanos-io:main Nov 6, 2021
@yeya24 yeya24 mentioned this pull request Nov 6, 2021
Closed
@yeya24 yeya24 mentioned this pull request Dec 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiedriusS GiedriusS GiedriusS left review comments

@yeya24 yeya24 yeya24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Have easier to way to tell the progress of compactor (and downsampling)
3 participants
@metonymic-smokey @GiedriusS @yeya24