Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Add flag --selector.relabel-config-file / --selector.relabel-config / --max-time / --min-time to filter served blocks. #4453

Merged
merged 7 commits into from
Jul 25, 2021

Conversation

hanjm
Copy link
Member

@hanjm hanjm commented Jul 19, 2021

fix #4452

Signed-off-by: hanjm hanjinming@outlook.com

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • add min-time max-time selector.relabel-config flag to thanos tools bucket web.

Verification

e2e test.
run with new flag, it works.

@hanjm hanjm changed the title Tool: bucket web support time filter and relabel filter (#4452) Tool: bucket web support time filter and relabel filter flag (#4452) Jul 19, 2021
@hanjm hanjm changed the title Tool: bucket web support time filter and relabel filter flag (#4452) Tools: Add flag --selector.relabel-config-file / --selector.relabel-config / --max-time / --min-time to filter served blocks. Jul 19, 2021
@hanjm hanjm force-pushed the feature/tool-bucket-web-support-relabel branch from 49d6996 to 873fbb6 Compare July 20, 2021 02:12
yeya24
yeya24 previously approved these changes Jul 20, 2021
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with only one nit. Thanks!

CHANGELOG.md Outdated Show resolved Hide resolved
@hanjm hanjm force-pushed the feature/tool-bucket-web-support-relabel branch 3 times, most recently from 8f41d70 to e07be14 Compare July 20, 2021 08:27
@hanjm hanjm requested a review from yeya24 July 21, 2021 13:33
Signed-off-by: hanjm <hanjinming@outlook.com>
Signed-off-by: hanjm <hanjinming@outlook.com>
Signed-off-by: hanjm <hanjinming@outlook.com>
Signed-off-by: hanjm <hanjinming@outlook.com>
@hanjm hanjm force-pushed the feature/tool-bucket-web-support-relabel branch from e07be14 to 452f4eb Compare July 24, 2021 09:34
Signed-off-by: hanjm <hanjinming@outlook.com>
@hanjm
Copy link
Member Author

hanjm commented Jul 24, 2021

I have add e2e test, @yeya24 could you help me review again? thank you.

yeya24
yeya24 previously approved these changes Jul 24, 2021
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! Just two small nits.

test/e2e/tools_bucket_web_test.go Show resolved Hide resolved
test/e2e/e2ethanos/services.go Show resolved Hide resolved
Signed-off-by: hanjm <hanjinming@outlook.com>
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yeya24 yeya24 merged commit 4c9c9b9 into thanos-io:main Jul 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tool: bucket web add relabel and time flag
2 participants