Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: Automated, per-endpoint mTLS #4377

Merged
merged 7 commits into from
Jul 15, 2021
Merged

proposal: Automated, per-endpoint mTLS #4377

merged 7 commits into from
Jul 15, 2021

Conversation

Namanl2001
Copy link
Contributor

Related issue: #977

@Namanl2001
proposal added
08e3f0c 
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
@Namanl2001
small nit
f8bc73d 
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
@Namanl2001 Namanl2001 mentioned this pull request Jun 30, 2021
Closed
bwplotka
bwplotka previously approved these changes Jul 1, 2021
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

Let's wait EOW for input from other maintainers @thanos-io/thanos-maintainers 🤗

cc @kakkoyun @squat @onprem @hitanshu-mehta (:

docs/proposals-accepted/202106-automated-per-endpoint-mTLS.md Outdated Show resolved Hide resolved
docs/proposals-accepted/202106-automated-per-endpoint-mTLS.md Outdated Show resolved Hide resolved
docs/proposals-accepted/202106-automated-per-endpoint-mTLS.md Outdated Show resolved Hide resolved
docs/proposals-accepted/202106-automated-per-endpoint-mTLS.md Outdated Show resolved Hide resolved
docs/proposals-accepted/202106-automated-per-endpoint-mTLS.md Outdated Show resolved Hide resolved
@Namanl2001
addressed comments
941b574 
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
@Namanl2001
make docs
0c0f38d 
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
bill3tt
bill3tt reviewed Jul 6, 2021
View reviewed changes
Copy link
Contributor

@bill3tt bill3tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice proposal 👍 I think you are articulating a problem that causes people pain, and I think we are on track to a neat solution.

docs/proposals-accepted/202106-automated-per-endpoint-mTLS.md Show resolved Hide resolved
docs/proposals-accepted/202106-automated-per-endpoint-mTLS.md Show resolved Hide resolved
docs/proposals-accepted/202106-automated-per-endpoint-mTLS.md Show resolved Hide resolved
@Namanl2001
small nit
86cb295 
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
@Namanl2001
alternative: querier per-certificate realm
b20f4bb 
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
@Namanl2001
small nit
a2351c1 
Signed-off-by: Namanl2001 <namanlakhwani@gmail.com>
kakkoyun
kakkoyun approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Great work!

@kakkoyun kakkoyun merged commit 47ee7df into thanos-io:main Jul 15, 2021
@GiedriusS
Copy link
Member

TBH I was thinking about implementing something like this via #2226 i.e. attach this kind of configuration to the store configuration however this works too, probably a bit more flexible when you can detach one from another

@Namanl2001 Namanl2001 deleted the proposal-mTLS branch July 15, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bill3tt bill3tt bill3tt left review comments

@bwplotka bwplotka bwplotka left review comments

@GiedriusS GiedriusS GiedriusS left review comments

@kakkoyun kakkoyun kakkoyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Namanl2001 @GiedriusS @kakkoyun @bwplotka @bill3tt