fix: sidecar: reloader: fix output config file permission #4308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you point this PR to the |
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
|
Ok, gotta do some git magic to fix the diff. gimme a few. |
Fixes: 4307 Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
OGKevin
force-pushed
the
4307-fix-permission-bug
branch
from
32526f5
to
a1c0ba3
Compare
|
Done |
onprem
pushed a commit
that referenced
this pull request
Jun 4, 2021
Fixes: 4307 Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
kakkoyun
pushed a commit
that referenced
this pull request
Jun 10, 2021
* Cut v0.21.0-rc.0 Signed-off-by: Prem Saraswat <prmsrswt@gmail.com> * Cut v0.21.0 Signed-off-by: Prem Saraswat <prmsrswt@gmail.com> * fix: sidecar: reloader: fix output config file permission (#4308) Fixes: 4307 Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com> * Fixed CHANGELOG for 0.21.1 Signed-off-by: Prem Saraswat <prmsrswt@gmail.com> * Cut release v0.21.1 Signed-off-by: Prem Saraswat <prmsrswt@gmail.com> * Revert version change Signed-off-by: Prem Saraswat <prmsrswt@gmail.com> Co-authored-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #4307
Changes
Revert back permission change of reloader made in #4173
Verification
Used https://github.com/users/OGKevin/packages/container/package/thanos and works as before 👌🏾