-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: add dark theme #4249
UI: add dark theme #4249
Conversation
17e1da1
to
895fd18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OMG we need this.
Thanks! It looks good on outside, but we need @onprem blessing here 🙈
This pull request seems to copy/paste code from Prometheus without the attribution required by the Apache-2 License. |
895fd18
to
a0a056b
Compare
@roidelapluie To maintain consistency in Thanos and Prometheus UI, I reused the Prometheus dark theme code. |
a0a056b
to
6186032
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Noob question: Is there a way to directly import the theme from Prometheus rather than copying over the code? It'll be hard to keep it in sync?
Currently, no. We have to publish relevant bits on npm to do that. |
Signed-off-by: Aman Dwivedi <aman.dwivedi5@gmail.com>
Signed-off-by: Aman Dwivedi <aman.dwivedi5@gmail.com>
6186032
to
b5d37ee
Compare
I only fixed the merged conflict. The dismissed stale reviews is due to saacs/github#1157 |
Changes
Added dark theme
Closes #3775
Screenshots
Homepage
Status page
Store page
Verification
cd pkg/ui/react-app/ yarn start